mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	rcu@vger.kernel.org, Frederic Weisbecker <fweisbec@gmail.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [RCU] rcu_tasks_trace_qs(): trc_reader_special.b.need_qs value incorrect likely()?
Date: Sat, 2 Dec 2023 18:45:07 -0500	[thread overview]
Message-ID: <20231202184507.26178c17@rorschach.local.home> (raw)
In-Reply-To: <b0772bf3-5b47-4aea-b964-17a2bebc6313@paulmck-laptop>

On Sat, 2 Dec 2023 14:24:26 -0800
"Paul E. McKenney" <paulmck@kernel.org> wrote:

> > Note, the unlikely tracing is running on my production server v6.6.3.
> > 
> > The above trace is from my test box with latest Linus's tree.  
> 
> Nice tool!!!

Thanks! It's only been in the kernel since 2008 ;-)

  1f0d69a9fc815 ("tracing: profile likely and unlikely annotations")

> 
> My kneejerk reaction is that that condition is suboptimal.  Does the 
> (untested) patch below help things?

I'll give it a try on Monday.

Thanks,

-- Steve

  reply	other threads:[~2023-12-02 23:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 20:49 Steven Rostedt
2023-12-02 22:24 ` Paul E. McKenney
2023-12-02 23:45   ` Steven Rostedt [this message]
2023-12-05 20:59     ` Steven Rostedt
2023-12-05 22:01       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231202184507.26178c17@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®