From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D75BC4167B for ; Mon, 4 Dec 2023 16:18:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344634AbjLDQSP (ORCPT ); Mon, 4 Dec 2023 11:18:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234647AbjLDQSN (ORCPT ); Mon, 4 Dec 2023 11:18:13 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E8DFAC for ; Mon, 4 Dec 2023 08:18:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 973F5C433C7; Mon, 4 Dec 2023 16:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701706698; bh=yDzvwMVlTobByjnSGQyneCW0HtTxC52ddIxe9fPN3os=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVhD/UgOk1VH4nMhaGXfD+m1K9OZ5rYZIk/4Fnx8Zai+cX+Z64vYDI4IF5wcKSh/D 5a+Y6PJmU/ZdqYtRoPiBgMb9JGDHucFAw8CE/0gZNt52NJGeYnd95Lh6VnJKhtdAZJ lp3EQhooN/WZKn1+TJwikNDjcNKnmzp/fRF8LaWg+NLHtlUuvyKifnu4c0jlT26m2M UI2tylugntqs7ftIW2ItBr4i+4wBX+gDSGIBn47eDW934px7h8FI2GvF0wPpfJmZmP tvpLOjlMidIQuvbUEo5Kb+TkLZbFwGcoXZpGM4wLutiougqtkIeilJAb1wAI3hO46B yHYQ81+c+mZyg== Date: Mon, 4 Dec 2023 16:18:13 +0000 From: Conor Dooley To: Inochi Amaoto Cc: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Chen Wang , Anup Patel , Samuel Holland , Guo Ren , Jisheng Zhang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v5 1/2] dt-bindings: timer: thead,c900-aclint-mtimer: separate mtime and mtimecmp regs Message-ID: <20231204-germproof-venue-6874ad902323@spud> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r7TrBvfH2EyTxEDe" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --r7TrBvfH2EyTxEDe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 04, 2023 at 05:51:08PM +0800, Inochi Amaoto wrote: > The timer registers of aclint don't follow the clint layout and can > be mapped on any different offset. As sg2042 uses separated timer > and mswi for its clint, it should follow the aclint spec and have > separated registers. >=20 > The previous patch introduced a new type of T-HEAD aclint timer which > has clint timer layout. Although it has the clint timer layout, it > should follow the aclint spec and uses the separated mtime and mtimecmp > regs. So a ABI change is needed to make the timer fit the aclint spec. >=20 > To make T-HEAD aclint timer more closer to the aclint spec, use > regs-names to represent the mtimecmp register, which can avoid hack > for unsupport mtime register of T-HEAD aclint timer. >=20 > Also, as T-HEAD aclint only supports mtimecmp, it is unnecessary to > implement the whole aclint spec. To make this binding T-HEAD specific, > only add reg-name for existed register. For details, see the discussion > in the last link. >=20 > Signed-off-by: Inochi Amaoto > Fixes: 4734449f7311 ("dt-bindings: timer: Add Sophgo sg2042 CLINT timer") > Link: https://lists.infradead.org/pipermail/opensbi/2023-October/005693.h= tml > Link: https://github.com/riscv/riscv-aclint/blob/main/riscv-aclint.adoc > Link: https://lore.kernel.org/all/IA1PR20MB4953F9D77FFC76A9D236922DBBB6A@= IA1PR20MB4953.namprd20.prod.outlook.com/ Acked-by: Conor Dooley Although, I figure it is going to be me that ends up taking it. Cheers, Conor. --r7TrBvfH2EyTxEDe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZW37xQAKCRB4tDGHoIJi 0k7+AQCD3i9MlUls5AeaNYbwXSKbbrJ8nrMswlOtYuKpALuxgwD/c5t5zE8FQyWQ gFvWp6AcxMmNv+4b61lJDPWZ+Mrm+Qc= =VXzQ -----END PGP SIGNATURE----- --r7TrBvfH2EyTxEDe--