From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DE3C4167B for ; Mon, 4 Dec 2023 13:54:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344744AbjLDNyi (ORCPT ); Mon, 4 Dec 2023 08:54:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235718AbjLDNye (ORCPT ); Mon, 4 Dec 2023 08:54:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 203191A1 for ; Mon, 4 Dec 2023 05:54:37 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07BB4C433C7; Mon, 4 Dec 2023 13:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701698076; bh=Yt42qsEglskrxT0sttipdDbX/oRzAJS4t3qsL4MIXac=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=N9Jvulx4+op58wlpRaJzIAuECstRCWjq/nxT0DeBL9bRqlLJ2fssUrqoAro3wHkp+ UAVCyq1xy1g2tg9im3QNoJEXQ4wREkbzNcYHoS6ki7eI/KhGaAsfVbbg4qh23igNI5 hBskAtgsVPyHUSQcw/Zv5LPHkGyKcJl4kx4W7S1O9KRs8AFgcPnW80EXkh1N7OZiiK iNEPmY0gqEuyZHfH4Zq54y+ni9XgnP+EfeVUj3zeElsCWktr3GFvCrWO7JxUADi4Na mWwvY3A0IYSMd1ty9KoWCuyNYO1ybmiWQIDA6y2d9tO5lDYBEbFwkEAvH3v+OBWIo/ WH4woiVcNIqDw== Date: Mon, 4 Dec 2023 13:54:30 +0000 From: Jonathan Cameron To: Cc: , , , , Subject: Re: [PATCH v2] iio: adc: MCP3564: fix hardware identification logic Message-ID: <20231204135430.603709a9@jic23-huawei> In-Reply-To: <20231129135619.63475-1-marius.cristea@microchip.com> References: <20231129135619.63475-1-marius.cristea@microchip.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Nov 2023 15:56:19 +0200 wrote: > From: Marius Cristea > > In mcp3564_config() fix the hardware identification logic > based on the hardware ID registers. Second part of the code was > disabled by an logic error. > Fix a typo related to the "MODULE_DESCRIPTION". > > Fixes: 33ec3e5fc1ea (iio: adc: adding support for MCP3564 ADC) > Signed-off-by: Marius Cristea Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/adc/mcp3564.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c > index e3f1de5fcc5a..e914a885a868 100644 > --- a/drivers/iio/adc/mcp3564.c > +++ b/drivers/iio/adc/mcp3564.c > @@ -1122,7 +1122,7 @@ static int mcp3564_config(struct iio_dev *indio_dev) > enum mcp3564_ids ids; > int ret = 0; > unsigned int tmp = 0x01; > - bool err = true; > + bool err = false; > > /* > * The address is set on a per-device basis by fuses in the factory, > @@ -1509,5 +1509,5 @@ static struct spi_driver mcp3564_driver = { > module_spi_driver(mcp3564_driver); > > MODULE_AUTHOR("Marius Cristea "); > -MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP346xR ADCs"); > +MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP356xR ADCs"); > MODULE_LICENSE("GPL v2"); > > base-commit: 6543f376ec8aa90a6c1ed44b765f4f0d6c3eb1db