From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFD9C4167B for ; Mon, 4 Dec 2023 18:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231693AbjLDSN4 (ORCPT ); Mon, 4 Dec 2023 13:13:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbjLDSNy (ORCPT ); Mon, 4 Dec 2023 13:13:54 -0500 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3954AAA; Mon, 4 Dec 2023 10:14:00 -0800 (PST) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3B4IDbCW030984; Mon, 4 Dec 2023 12:13:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1701713617; bh=gBm0LfcmnjffiadImNafTIQvyRQvPbA+iykRWhDjM1M=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=bcUBzEZyT7Gk+HMhgnsKD6Xr9HroCug1xxq6sHkrBDG5WtBONkkwyVsMyn4b8Zv6H QRe/fNmjjZR6JJILFXCkOagZGJ6MxOXmST0fbLDr35+uiaJoa2/1evXDYOS3DMQovV zJn8csvQ0P+6CDj0LrjosO23sXJn/6hI6Dh2GAiU= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3B4IDbjk086570 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 Dec 2023 12:13:37 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 4 Dec 2023 12:13:36 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 4 Dec 2023 12:13:36 -0600 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3B4IDaLh080036; Mon, 4 Dec 2023 12:13:36 -0600 Date: Mon, 4 Dec 2023 12:13:36 -0600 From: Nishanth Menon To: Francesco Dolcini CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joao Paulo Goncalves , , , , Francesco Dolcini Subject: Re: [PATCH v2 3/3] arm64: dts: ti: add verdin am62 mallow board Message-ID: <20231204181336.scm2fgfyyzpr2u7t@dimmer> References: <20231201145551.23337-1-francesco@dolcini.it> <20231201145551.23337-4-francesco@dolcini.it> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231201145551.23337-4-francesco@dolcini.it> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15:55-20231201, Francesco Dolcini wrote: > From: Joao Paulo Goncalves [...] > + > + tpm@1 { > + compatible = "infineon,slb9670", "tcg,tpm_tis-spi"; arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] We should either drop this node OR introduce bindings and later introduce this series. Yes, I know there are other places where the compatible is already used arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts etc.. But, unfortunately, I'd rather see the binding Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt transition over to yaml prior to picking things up. (NOTE: the same rules apply to TI devs as well..) > + reg = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_qspi1_dqs_gpio>; > + interrupt-parent = <&main_gpio1>; > + interrupts = <18 IRQ_TYPE_EDGE_FALLING>; > + spi-max-frequency = <18500000>; [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D