From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] tracing: Always update snapshot buffer size
Date: Tue, 5 Dec 2023 12:35:14 -0500 [thread overview]
Message-ID: <20231205123514.03244a4e@gandalf.local.home> (raw)
In-Reply-To: <20231205115223.5256e1a1@gandalf.local.home>
On Tue, 5 Dec 2023 11:52:23 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> It use to be that only the top level instance had a snapshot buffer (for
> latency tracers like wakeup and irqsoff). The update of the ring buffer
> size would check if the instance was the top level and if so, it would
> also update the snapshot buffer as it needs to be the same as the main
> buffer.
>
> Now that lower level instances also has a snapshot buffer, they too need
> to update their snapshot buffer sizes when the main buffer is changed,
> otherwise the following can be triggered:
>
> # cd /sys/kernel/tracing
> # echo 1500 > buffer_size_kb
> # mkdir instances/foo
> # echo irqsoff > instances/foo/current_tracer
> # echo 1000 > instances/foo/buffer_size_kb
>
Bah, this is only a partial patch, in fact it doesn't even fix the issue.
It fixes another issue that this issue is dependent on.
I'll send out a v2 shortly.
-- Steve
prev parent reply other threads:[~2023-12-05 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 16:52 Steven Rostedt
2023-12-05 17:35 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205123514.03244a4e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®