From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F3EC46CA3 for ; Tue, 5 Dec 2023 13:06:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345377AbjLENGm (ORCPT ); Tue, 5 Dec 2023 08:06:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235139AbjLENGk (ORCPT ); Tue, 5 Dec 2023 08:06:40 -0500 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D370E120 for ; Tue, 5 Dec 2023 05:06:46 -0800 (PST) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3B56mS2Q002076; Tue, 5 Dec 2023 07:06:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s= PODMain02222019; bh=esZIg4k1vejK+Ovs7uaHd37lyuP5a7qtqkhY+WqTKN8=; b= REsYKDffvO6WSkLUBPuJqg5zx/Xw+dOkgw7s4T+fDRZE3MNyC0YDoLuv3GXpdFcX r6+ickhYpwQraDZa2+wUO3N7D9ou/774jDO+8rTLxUpS/l0bDYyOYtNJAIcNDdy/ Ui1atJr/lBCnV6jalZKSWbvJOLZB/BLYRoz+ts+KXu3ZT92x2LhLn66lhppu5dMI pCjmOZZdiU7cqXTaUaEL95WtFvGflpoQMCJhIjmOMs3CUwKurunn88h2f520wIYk 74EM2cJvd4HYVGH86WQfGYhva7BOJgxLb76dTBInJR/vcuf9ogVk3auPO6D5w9Jc L+Hj8y8CmPXY3xovrQ1fyw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3ur2v236e4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Dec 2023 07:06:33 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 5 Dec 2023 13:06:31 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Tue, 5 Dec 2023 13:06:31 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id B6B1C474; Tue, 5 Dec 2023 13:06:31 +0000 (UTC) Date: Tue, 5 Dec 2023 13:06:31 +0000 From: Charles Keepax To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: Liam Girdwood , Mark Brown , , , Subject: Re: [PATCH 1/8] regulator: arizona-ldo1: Convert to platform remove callback returning void Message-ID: <20231205130631.GE14858@ediswmail.ad.cirrus.com> References: <76c7af01e2c8b3ab6585a04bc3f0d163fbb7fdf7.1701778038.git.u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <76c7af01e2c8b3ab6585a04bc3f0d163fbb7fdf7.1701778038.git.u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: SjEKKDuG7L3EtcdDoAJUFpHPalutlvn1 X-Proofpoint-GUID: SjEKKDuG7L3EtcdDoAJUFpHPalutlvn1 X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 05, 2023 at 01:26:16PM +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- Acked-by: Charles Keepax Thanks, Charles