mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kamel Bouhara <kamel.bouhara@bootlin.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Marco Felsch <m.felsch@pengutronix.de>,
	Jeff LaBundy <jeff@labundy.com>
Cc: oe-kbuild-all@lists.linux.dev,
	catalin.popescu@leica-geosystems.com,
	mark.satterthwaite@touchnetix.com, bartp@baasheep.co.uk,
	hannah.rossiter@touchnetix.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	bsp-development.geo@leica-geosystems.com,
	Kamel Bouhara <kamel.bouhara@bootlin.com>
Subject: Re: [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
Date: Tue, 5 Dec 2023 14:36:23 +0800	[thread overview]
Message-ID: <202312051457.y3N1q3sZ-lkp@intel.com> (raw)
In-Reply-To: <20231204140505.2838916-4-kamel.bouhara@bootlin.com>

Hi Kamel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on dtor-input/next]
[also build test WARNING on dtor-input/for-linus robh/for-next linus/master krzk-dt/for-next v6.7-rc4 next-20231204]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kamel-Bouhara/dt-bindings-vendor-prefixes-Add-TouchNetix-AS/20231204-222017
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link:    https://lore.kernel.org/r/20231204140505.2838916-4-kamel.bouhara%40bootlin.com
patch subject: [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231205/202312051457.y3N1q3sZ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051457.y3N1q3sZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051457.y3N1q3sZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/input/touchscreen/touchnetix_axiom.c: In function 'axiom_usage_to_target_address':
>> drivers/input/touchscreen/touchnetix_axiom.c:142:31: warning: variable 'device_info' set but not used [-Wunused-but-set-variable]
     142 |         struct axiom_devinfo *device_info;
         |                               ^~~~~~~~~~~


vim +/device_info +142 drivers/input/touchscreen/touchnetix_axiom.c

   136	
   137	/* Translate usage/page/offset triplet into physical address. */
   138	static u16 axiom_usage_to_target_address(struct axiom_data *ts, char usage, char page,
   139						 char offset)
   140	{
   141		struct axiom_usage_entry *usage_table;
 > 142		struct axiom_devinfo *device_info;
   143		u32 i;
   144	
   145		device_info = &ts->devinfo;
   146		usage_table = ts->usage_table;
   147	
   148		/* At the moment the convention is that u31 is always at physical address 0x0 */
   149		if (!ts->usage_table_populated) {
   150			if (usage == AXIOM_DEVINFO_USAGE_ID)
   151				return ((page << 8) + offset);
   152			else
   153				return 0xffff;
   154		}
   155	
   156		for (i = 0; i < ts->devinfo.num_usages; i++) {
   157			if (usage_table[i].id != usage)
   158				continue;
   159	
   160			if (page >= usage_table[i].num_pages) {
   161				dev_err(ts->dev, "Invalid usage table! usage: %u, page: %u, offset: %u\n",
   162					usage, page, offset);
   163				return 0xffff;
   164			}
   165			break;
   166		}
   167	
   168		return ((usage_table[i].start_page + page) << 8) + offset;
   169	}
   170	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2023-12-05  6:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 14:05 [PATCH v4 0/3] Input: Add TouchNetix axiom " Kamel Bouhara
2023-12-04 14:05 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS Kamel Bouhara
2023-12-04 14:05 ` [PATCH v4 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen Kamel Bouhara
2023-12-05  8:15   ` Krzysztof Kozlowski
2023-12-05  9:17     ` Kamel BOUHARA
2023-12-05  9:26       ` Krzysztof Kozlowski
2023-12-04 14:05 ` [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver Kamel Bouhara
2023-12-04 15:09   ` POPESCU Catalin
2023-12-04 16:16     ` Kamel Bouhara
2023-12-05  6:36   ` kernel test robot [this message]
2023-12-07  5:28   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202312051457.y3N1q3sZ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bartp@baasheep.co.uk \
    --cc=bsp-development.geo@leica-geosystems.com \
    --cc=catalin.popescu@leica-geosystems.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregory.clement@bootlin.com \
    --cc=hannah.rossiter@touchnetix.com \
    --cc=jeff@labundy.com \
    --cc=kamel.bouhara@bootlin.com \
    --cc=krzk@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=mark.satterthwaite@touchnetix.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®