From: kernel test robot <lkp@intel.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
song@kernel.org, xni@redhat.com, yukuai3@huawei.com,
neilb@suse.com
Cc: oe-kbuild-all@lists.linux.dev, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai1@huaweicloud.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v4 md-fixes 3/3] md: fix stopping sync thread
Date: Tue, 5 Dec 2023 17:14:25 +0800 [thread overview]
Message-ID: <202312051758.ZlpYxGpJ-lkp@intel.com> (raw)
In-Reply-To: <20231204135732.3647886-4-yukuai1@huaweicloud.com>
Hi Yu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on song-md/md-next]
[also build test WARNING on linus/master v6.7-rc4 next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/md-fix-missing-flush-of-sync_work/20231204-215956
base: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
patch link: https://lore.kernel.org/r/20231204135732.3647886-4-yukuai1%40huaweicloud.com
patch subject: [PATCH v4 md-fixes 3/3] md: fix stopping sync thread
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231205/202312051758.ZlpYxGpJ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051758.ZlpYxGpJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051758.ZlpYxGpJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/md/md.c: In function 'idle_sync_thread':
>> drivers/md/md.c:4897:13: warning: unused variable 'sync_seq' [-Wunused-variable]
4897 | int sync_seq = atomic_read(&mddev->sync_seq);
| ^~~~~~~~
vim +/sync_seq +4897 drivers/md/md.c
64e5e09afc14f8 Yu Kuai 2023-05-29 4894
64e5e09afc14f8 Yu Kuai 2023-05-29 4895 static void idle_sync_thread(struct mddev *mddev)
64e5e09afc14f8 Yu Kuai 2023-05-29 4896 {
130443d60b1b8c Yu Kuai 2023-05-29 @4897 int sync_seq = atomic_read(&mddev->sync_seq);
130443d60b1b8c Yu Kuai 2023-05-29 4898
6f56f0c4f1241f Yu Kuai 2023-05-29 4899 mutex_lock(&mddev->sync_mutex);
64e5e09afc14f8 Yu Kuai 2023-05-29 4900 clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
130443d60b1b8c Yu Kuai 2023-05-29 4901
fde7b408a7cb14 Yu Kuai 2023-12-04 4902 if (mddev_lock(mddev)) {
fde7b408a7cb14 Yu Kuai 2023-12-04 4903 mutex_unlock(&mddev->sync_mutex);
fde7b408a7cb14 Yu Kuai 2023-12-04 4904 return;
fde7b408a7cb14 Yu Kuai 2023-12-04 4905 }
130443d60b1b8c Yu Kuai 2023-05-29 4906
fde7b408a7cb14 Yu Kuai 2023-12-04 4907 stop_sync_thread(mddev, false, true);
6f56f0c4f1241f Yu Kuai 2023-05-29 4908 mutex_unlock(&mddev->sync_mutex);
64e5e09afc14f8 Yu Kuai 2023-05-29 4909 }
64e5e09afc14f8 Yu Kuai 2023-05-29 4910
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-12-05 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 13:57 [PATCH v4 md-fixes 0/3] " Yu Kuai
2023-12-04 13:57 ` [PATCH v4 md-fixes 1/3] md: fix missing flush of sync_work Yu Kuai
2023-12-04 13:57 ` [PATCH v4 md-fixes 2/3] md: don't leave 'MD_RECOVERY_FROZEN' in error path of md_set_readonly() Yu Kuai
2023-12-04 13:57 ` [PATCH v4 md-fixes 3/3] md: fix stopping sync thread Yu Kuai
2023-12-05 9:14 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312051758.ZlpYxGpJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®