From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7DFC10F04 for ; Tue, 5 Dec 2023 11:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442033AbjLELPY (ORCPT ); Tue, 5 Dec 2023 06:15:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345052AbjLELPW (ORCPT ); Tue, 5 Dec 2023 06:15:22 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93871124 for ; Tue, 5 Dec 2023 03:15:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701774928; x=1733310928; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ztw1slu3TaA4rUwHsafEEGA9mY1oz7LTl5MSrHnmkBM=; b=ee/ImYFuKhADZ7IpLfqrZ7b2sdvUEhi8BLXBNIafvA+9U4bRC0tBO6RR b4mOlgq39JXG3gjBVI82GU93T3fCftxu4NAMEi62A8MA3fePZIqZZsD/V YHjI0HiA9Tn32a14dLIgYSYe4Sfzf/2IjCcs+gyyxKXu3YLqz+IXDllj6 m/bcloPloVYrFZ6cOQze+VFNYL3WtKQH6ED+dQYPaGcs4FL4zzERffXUM p/CsSmWv+GSmWjrHsSx7fJu4STLs8AzOmZK08NbeULPJ/U87i0ltKXrqZ 4v2XaEZ45hSA7v2RwWx22/pzVGupdcVjsIvsGg/6pImaqsxnFVsnWrNo3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="15427261" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="15427261" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 03:15:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="799943800" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="799943800" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga008.jf.intel.com with ESMTP; 05 Dec 2023 03:15:26 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rATOe-0008qY-0G; Tue, 05 Dec 2023 11:15:24 +0000 Date: Tue, 5 Dec 2023 19:15:07 +0800 From: kernel test robot To: Haoran Liu , support.opensource@diasemi.com Cc: oe-kbuild-all@lists.linux.dev, lee@kernel.org, linux-kernel@vger.kernel.org, Haoran Liu Subject: Re: [PATCH] [mfd] da9052: Add error handling for spi_setup in da9052_spi_probe Message-ID: <202312051908.qxoHjGkx-lkp@intel.com> References: <20231203052125.37334-1-liuhaoran14@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231203052125.37334-1-liuhaoran14@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Haoran, kernel test robot noticed the following build errors: [auto build test ERROR on lee-mfd/for-mfd-next] [also build test ERROR on lee-leds/for-leds-next lee-mfd/for-mfd-fixes linus/master v6.7-rc4 next-20231205] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Haoran-Liu/da9052-Add-error-handling-for-spi_setup-in-da9052_spi_probe/20231203-132410 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next patch link: https://lore.kernel.org/r/20231203052125.37334-1-liuhaoran14%40163.com patch subject: [PATCH] [mfd] da9052: Add error handling for spi_setup in da9052_spi_probe config: i386-buildonly-randconfig-004-20231203 (https://download.01.org/0day-ci/archive/20231205/202312051908.qxoHjGkx-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051908.qxoHjGkx-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312051908.qxoHjGkx-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/mfd/da9052-spi.c: In function 'da9052_spi_probe': >> drivers/mfd/da9052-spi.c:25:6: error: redeclaration of 'ret' with no linkage int ret; ^~~ drivers/mfd/da9052-spi.c:22:6: note: previous declaration of 'ret' was here int ret; ^~~ vim +/ret +25 drivers/mfd/da9052-spi.c 18 19 static int da9052_spi_probe(struct spi_device *spi) 20 { 21 struct regmap_config config; 22 int ret; 23 const struct spi_device_id *id = spi_get_device_id(spi); 24 struct da9052 *da9052; > 25 int ret; 26 27 da9052 = devm_kzalloc(&spi->dev, sizeof(struct da9052), GFP_KERNEL); 28 if (!da9052) 29 return -ENOMEM; 30 31 spi->mode = SPI_MODE_0; 32 spi->bits_per_word = 8; 33 ret = spi_setup(spi); 34 if (ret) { 35 dev_err(&spi->dev, "spi_setup failed: %d\n", ret); 36 return ret; 37 } 38 39 da9052->dev = &spi->dev; 40 da9052->chip_irq = spi->irq; 41 42 spi_set_drvdata(spi, da9052); 43 44 config = da9052_regmap_config; 45 config.read_flag_mask = 1; 46 config.reg_bits = 7; 47 config.pad_bits = 1; 48 config.val_bits = 8; 49 config.use_single_read = true; 50 config.use_single_write = true; 51 52 da9052->regmap = devm_regmap_init_spi(spi, &config); 53 if (IS_ERR(da9052->regmap)) { 54 ret = PTR_ERR(da9052->regmap); 55 dev_err(&spi->dev, "Failed to allocate register map: %d\n", 56 ret); 57 return ret; 58 } 59 60 return da9052_device_init(da9052, id->driver_data); 61 } 62 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki