From: kernel test robot <lkp@intel.com>
To: Kent Overstreet <kmo@daterainc.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: fs/bcachefs/extents.c:386:5-8: Unneeded variable: "ret". Return " 0" on line 392
Date: Wed, 6 Dec 2023 12:54:32 +0800 [thread overview]
Message-ID: <202312061232.UwWyjKnI-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
commit: b65db750e2bb9252321fd54c284edd73c1595a09 bcachefs: Enumerate fsck errors
date: 5 weeks ago
config: x86_64-randconfig-104-20231204 (https://download.01.org/0day-ci/archive/20231206/202312061232.UwWyjKnI-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20231206/202312061232.UwWyjKnI-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312061232.UwWyjKnI-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/extents.c:386:5-8: Unneeded variable: "ret". Return " 0" on line 392
--
>> fs/bcachefs/snapshot.c:37:5-8: Unneeded variable: "ret". Return " 0" on line 44
fs/bcachefs/snapshot.c:212:5-8: Unneeded variable: "ret". Return " 0" on line 259
vim +386 fs/bcachefs/extents.c
380
381 int bch2_reservation_invalid(struct bch_fs *c, struct bkey_s_c k,
382 enum bkey_invalid_flags flags,
383 struct printbuf *err)
384 {
385 struct bkey_s_c_reservation r = bkey_s_c_to_reservation(k);
> 386 int ret = 0;
387
388 bkey_fsck_err_on(!r.v->nr_replicas || r.v->nr_replicas > BCH_REPLICAS_MAX, c, err,
389 reservation_key_nr_replicas_invalid,
390 "invalid nr_replicas (%u)", r.v->nr_replicas);
391 fsck_err:
> 392 return ret;
393 }
394
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-06 4:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312061232.UwWyjKnI-lkp@intel.com \
--to=lkp@intel.com \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®