From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32AC9C10DC3 for ; Thu, 7 Dec 2023 17:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443200AbjLGRM5 (ORCPT ); Thu, 7 Dec 2023 12:12:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjLGRM4 (ORCPT ); Thu, 7 Dec 2023 12:12:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A09DFE0 for ; Thu, 7 Dec 2023 09:13:02 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D25CC433C7; Thu, 7 Dec 2023 17:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701969182; bh=CWq54dj8Wontm3jMWlBjKGW8W5yeehl6dhE489SUR0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SIvadOdHqMIfBJnkKTHoWVdlW8stNFjOoGAqwWatdV0l62gCGKrkk3vEGRrcJNNQU CVfXX1kdAwdCkc1H2SpMyvF/yshcbXXRM+Efstw6ONK+jSMbsH1Nbf7ewZ/jDaQOjb o/WQ8wUapc/gl4abDD233akB8mpK5dbASCt1LCu1scD38vczeh0/U0mJEvJv6UA7DF VXklf2x97dLHxLnyILc4UEWw/RODCKbh65qnUvomFD5eGlieWgTy3DHrDfEP0HSA3M NHUAHRCT2S1rgK7gIA+Kt0dII0WpCmAAlhGsEewGzwQoLZPrd6tHUhvlc5Drcf0Lfq v0Yu2s0WNPzCA== Date: Thu, 7 Dec 2023 17:12:57 +0000 From: Conor Dooley To: Elad Nachman Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, mrkiko.rs@gmail.com, chris.packham@alliedtelesis.co.nz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cyuval@marvell.com Subject: Re: [PATCH v7 2/3] dt-bindings: arm64: add Marvell COM Express boards Message-ID: <20231207-dallying-tablet-c5f32f91373c@spud> References: <20231207143248.2439926-1-enachman@marvell.com> <20231207143248.2439926-3-enachman@marvell.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d2AP0+yTHV6MnsnX" Content-Disposition: inline In-Reply-To: <20231207143248.2439926-3-enachman@marvell.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --d2AP0+yTHV6MnsnX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 07, 2023 at 04:32:47PM +0200, Elad Nachman wrote: > From: Elad Nachman >=20 > Add dt bindings for: > CN9130 COM Express CPU module > CN9131 COM Express CPU module > AC5X RD COM Express Type 7 carrier board. > AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module. >=20 > Signed-off-by: Elad Nachman > --- > .../bindings/arm/marvell/armada-7k-8k.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.y= aml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..d00866aeaa8d 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,28 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > =20 > + - description: > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier = plus > + Armada CN9130 COM Express CPU module > + items: > + - enum: > + - marvell,cn9130-ac5x-carrier There's so many compatibles here that it is a bit hard for me to follow, but I am wondering why you have the "enum" here. The description seems to define this as being for one specific carrier and you have two entries here for carriers compatible with the rd-ac5x. It looks like you should either a) combine both of these or b) swap the enum for const. Thanks, Conor. > + - const: marvell,rd-ac5x-carrier > + - const: marvell,cn9130-cpu-module > + - const: marvell,cn9130 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > + - description: > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier = plus > + Armada CN9131 COM Express CPU module > + items: > + - enum: > + - marvell,cn9131-ac5x-carrier > + - const: marvell,rd-ac5x-carrier > + - const: marvell,cn9131-cpu-module > + - const: marvell,cn9131 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true > --=20 > 2.25.1 >=20 --d2AP0+yTHV6MnsnX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXH9GQAKCRB4tDGHoIJi 0nN2AQCqThk3YPq4l91eYo/Ek1s5Bu2ydkEspqikzp/UG0MxhAD+JGcDJ2d91XJp b/Zp56LDXRG9MZ7NMtXQKC69ErA4+go= =7TZ9 -----END PGP SIGNATURE----- --d2AP0+yTHV6MnsnX--