From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8C5C4167B for ; Thu, 7 Dec 2023 15:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443535AbjLGPfD (ORCPT ); Thu, 7 Dec 2023 10:35:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443494AbjLGPfB (ORCPT ); Thu, 7 Dec 2023 10:35:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B69210E3 for ; Thu, 7 Dec 2023 07:35:07 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1192FC433C7; Thu, 7 Dec 2023 15:35:05 +0000 (UTC) Date: Thu, 7 Dec 2023 10:35:36 -0500 From: Steven Rostedt To: Yuanhan Zhang Cc: Sebastian Andrzej Siewior , zyhtheonly@yeah.net, tglx@linutronix.de, mingo@redhat.com, Venkatesh Pallipadi , peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Subject: Re: [PATCH v3] sched/cputime: let ktimers align with ksoftirqd in accounting CPUTIME_SOFTIRQ Message-ID: <20231207103536.30ae05aa@gandalf.local.home> In-Reply-To: References: <20231201073240.T9bFNCkU@linutronix.de> <20231201080522.GA31309@didi-ThinkCentre-M930t-N000> <20231201161640.Z0cJLUi3@linutronix.de> <20231205153146.OSpCIs1G@linutronix.de> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Dec 2023 18:43:47 +0800 Yuanhan Zhang wrote: > It results in if we do not handle ksoftirqd like this, we will have a > bigger SYSTEM and less SOFTIRQ. And honestly that's what we want. Interrupts and softirqs that execute in interrupts and softirq context take away from the system. That is, if they are not explicitly blocked (local_irq_disable/local_bh_disable) they interrupt the current task and take up the time of the current task. We need to differentiate this because this context has no "task" context to measure. We do not want to add ksoftirqd or threaded interrupt handlers / softirqs to this measurement. Sure, they are handling interrupt and softirq code, but they have their own context that can be measured like any other task. If we blur this with real irqs and softirqs, then we will not know what those real irqs and softirqs are measuring. > So my point is if we do not align ktimers, ktimers would act like > **observation on *not-excluded ksoftirq patched* kernel** part in the > above example, > and this might make SOFTIRQ less than expected, /proc/stat less accurate. No it does not. When a softirq kicks off it's work to a thread (ksoftirq, threaded softirqd, or simply a workqueue), it's no longer running in softirq context, and should not be measured as such. The measurement is not about how much work the softirq is doing (otherwise we need to add workqueues started by softirqs too), it's about measuring the actual irq and softirq context. In PREEMPT_RT, we try to eliminate that context as much as possible. So seeing less is a feature not a bug! -- Steve