From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5323EC4167B for ; Thu, 7 Dec 2023 14:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443016AbjLGOJY (ORCPT ); Thu, 7 Dec 2023 09:09:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442978AbjLGOJV (ORCPT ); Thu, 7 Dec 2023 09:09:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D46AB10CB for ; Thu, 7 Dec 2023 06:09:27 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0B9C433C7; Thu, 7 Dec 2023 14:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701958167; bh=H4XF+LqR6lnW5axiIdnTAEfuhRgWdQr7OOX8znjsCwQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gXnRRnfdQToNJAuodRkXasWCP48sM3fMyS8EC6ilFDSGi0arEZSYiYdJyhCZpsZbt GiRohH6K3kZYMUQOsyz7cA2QzJExNzJivnJz3T1xeCp/1gQmn/ZF/CK6YzOQpvM+QS qCjKrjtKzFOpfEpbEtkURKSIie0/P+6ptCei62sxi+rtI9wPxTe2LhI7Ku4BaqQ7DE vaT7gDjWTmBCCFdKyIcm5cZwPIpeByQe3L75Fx/JcGDUFDav5a87o2umzIF3llBWSl 9lQc/rN7NMq2IcBv3K9jejz8aLd28UkbcLrdcsbuAoewClRPn76fCMaIkwQCjPmaJm qriPrsZUgZkxw== Date: Thu, 7 Dec 2023 15:09:17 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Sjoerd Simons Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] bus: moxtet: Mark the irq as shared Message-ID: <20231207150917.6f69999c@dellmb> In-Reply-To: <20231123142403.2262032-1-sjoerd@collabora.com> References: <20231123142403.2262032-1-sjoerd@collabora.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Nov 2023 15:23:37 +0100 Sjoerd Simons wrote: > The Turris Mox shares the moxtet IRQ with various devices on the board, > so mark the IRQ as shared in the driver as well. >=20 > Without this loading the module will fail with: > genirq: Flags mismatch irq 40. 00002002 (moxtet) vs. 00002080 (mcp7940x) >=20 > Signed-off-by: Sjoerd Simons > --- >=20 > drivers/bus/moxtet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c > index 5eb0fe73ddc4..48c18f95660a 100644 > --- a/drivers/bus/moxtet.c > +++ b/drivers/bus/moxtet.c > @@ -755,7 +755,7 @@ static int moxtet_irq_setup(struct moxtet *moxtet) > moxtet->irq.masked =3D ~0; > =20 > ret =3D request_threaded_irq(moxtet->dev_irq, NULL, moxtet_irq_thread_f= n, > - IRQF_ONESHOT, "moxtet", moxtet); > + IRQF_SHARED | IRQF_ONESHOT, "moxtet", moxtet); > if (ret < 0) > goto err_free; > =20 Reviewed-by: Marek Beh=C3=BAn