From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B3B4C4167B for ; Thu, 7 Dec 2023 14:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443030AbjLGOJf (ORCPT ); Thu, 7 Dec 2023 09:09:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443022AbjLGOJd (ORCPT ); Thu, 7 Dec 2023 09:09:33 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA84F10F0 for ; Thu, 7 Dec 2023 06:09:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEC8C433C9; Thu, 7 Dec 2023 14:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701958179; bh=BjBnV3kL3685DCGYUGVnlSe0u7QDs/DMd9WjbShQbns=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sEcFOS2fRrK0cHEs+GdHYd8OBAU1lM1XGk1JZz3CyZse9dNAqmkyLFZAWALoOyjpa 8yOnSK1d+btluKAcPL48bcIwjkKLBDpH4XOIUwmB2fljU2EqO+M4NbEzS2yLhxX33a MA/N0a09PldZbjpEyegrp2kgM0S7W48yhuI14QDsHzrzyv4gkAuZIub97KFcnwn9SO mI8cstM96MDHXkT3eii/RWcJhZeYzqErIn9VDUjEtq918Y0LKqwUnKzH06FLkieYes C1KRJoc9vVJhnJXNSG4ovMWi535JfrshGfd6GsWYu7kvUeaJuNA+jZYNXwtPt/IvTg LIquhHnqet4aQ== Date: Thu, 7 Dec 2023 15:09:35 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Sjoerd Simons Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] bus: moxtet: Add spi device table Message-ID: <20231207150935.1db44032@dellmb> In-Reply-To: <20231123142403.2262032-2-sjoerd@collabora.com> References: <20231123142403.2262032-1-sjoerd@collabora.com> <20231123142403.2262032-2-sjoerd@collabora.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Nov 2023 15:23:38 +0100 Sjoerd Simons wrote: > The moxtet module was failing to auto-load on my system. Add a SPI id > table to allow it to do so. >=20 > Signed-off-by: Sjoerd Simons >=20 > --- >=20 > drivers/bus/moxtet.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c > index 48c18f95660a..e384fbc6c1d9 100644 > --- a/drivers/bus/moxtet.c > +++ b/drivers/bus/moxtet.c > @@ -830,6 +830,12 @@ static void moxtet_remove(struct spi_device *spi) > mutex_destroy(&moxtet->lock); > } > =20 > +static const struct spi_device_id moxtet_spi_ids[] =3D { > + { "moxtet" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(spi, moxtet_spi_ids); > + > static const struct of_device_id moxtet_dt_ids[] =3D { > { .compatible =3D "cznic,moxtet" }, > {}, > @@ -841,6 +847,7 @@ static struct spi_driver moxtet_spi_driver =3D { > .name =3D "moxtet", > .of_match_table =3D moxtet_dt_ids, > }, > + .id_table =3D moxtet_spi_ids, > .probe =3D moxtet_probe, > .remove =3D moxtet_remove, > }; Reviewed-by: Marek Beh=C3=BAn