From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: paul.gortmaker@windriver.com, x86@kernel.org,
regressions@leemhuis.info, richard.purdie@linuxfoundation.org,
regressions@lists.linux.dev
Subject: [patch 1/2] x86/alternatives: Sync core before enabling interrupts
Date: Thu, 7 Dec 2023 20:49:24 +0100 (CET) [thread overview]
Message-ID: <20231207194518.341544943@linutronix.de> (raw)
In-Reply-To: <20231207193859.961361261@linutronix.de>
text_poke_early() does:
local_irq_save(flags);
memcpy(addr, opcode, len);
local_irq_restore(flags);
sync_core();
That's not really correct because the synchronization should happen before
interrupts are reenabled to ensure that a pending interrupt observes the
complete update of the opcodes.
It's not entirely clear whether the interrupt entry provides enough
serialization already, but moving the sync_core() invocation into interrupt
disabled region does no harm and is obviously correct.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -1685,8 +1685,8 @@ void __init_or_module text_poke_early(vo
} else {
local_irq_save(flags);
memcpy(addr, opcode, len);
- local_irq_restore(flags);
sync_core();
+ local_irq_restore(flags);
/*
* Could also do a CLFLUSH here to speed up CPU recovery; but
next prev parent reply other threads:[~2023-12-07 19:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 18:41 32 bit qemu regression from v6.5 tip pull [6c480f222128 x86/alternative: Rewrite optimize_nops() some] Paul Gortmaker
2023-10-30 8:26 ` Peter Zijlstra
2023-10-30 10:55 ` Richard Purdie
2023-10-30 11:44 ` Peter Zijlstra
2023-10-30 15:28 ` Paul Gortmaker
2023-10-30 18:24 ` Thomas Gleixner
2023-10-30 19:30 ` Thomas Gleixner
2023-10-31 15:40 ` Paul Gortmaker
2023-11-11 11:51 ` Linux regression tracking (Thorsten Leemhuis)
2023-11-22 14:11 ` Richard Purdie
2023-11-29 8:57 ` Thomas Gleixner
2023-12-06 15:46 ` Paul Gortmaker
2023-12-07 16:34 ` Thomas Gleixner
2023-12-07 16:52 ` Paul Gortmaker
2023-12-07 19:49 ` [patch 0/2] x86/alternatives: Prevent crash in NOP optimizer Thomas Gleixner
2023-12-07 19:49 ` Thomas Gleixner [this message]
2023-12-07 19:49 ` [patch 2/2] x86/alternatives: Disable interrupts and sync when optimizing NOPs in place Thomas Gleixner
2023-12-08 13:22 ` Borislav Petkov
2023-12-08 13:37 ` Thomas Gleixner
2023-12-08 8:35 ` [patch 0/2] x86/alternatives: Prevent crash in NOP optimizer Paul Gortmaker
2023-12-15 9:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207194518.341544943@linutronix.de \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=richard.purdie@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®