From: Armin Wolf <W_Armin@gmx.de>
To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, corbet@lwn.net
Cc: Dell.Client.Kernel@dell.com, linux-doc@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] platform/x86: wmi: Cleanup obsolete features
Date: Thu, 7 Dec 2023 23:26:18 +0100 [thread overview]
Message-ID: <20231207222623.232074-1-W_Armin@gmx.de> (raw)
This patch series removes three features deemed obsolete:
- the debug_dump_wdg module param:
- suffers from garbled output due to pr_cont()
- functionality is better provided by "fwts wmi"
- the debug_event module param:
- pr_cont() usage
- uses the deprecated GUID-based API
- largely replaced by the ACPI netlink interface
- ioctl interface
- used only by a single driver, no adoption otherwise
- numerous design issues
Since the ioctl interface is actually used by userspace programs,
the only user (the dell-smbios-wmi driver) was modified to implement
the necessary pieces itself so that no regressions are expected.
The last patch in contrast adds a short WMI driver development guide
to the WMI subsystem documentation, so that driver developers stop
submitting WMI drivers using the deprecated GUID-based interface.
The series depends on
commit cbf54f37600e ("platform/x86: wmi: Skip blocks with zero instances"),
which is currently in the "fixes" tree.
All patches where tested on a Dell Inspiron 3505 and work without
issues.
Armin Wolf (5):
platform/x86: wmi: Remove debug_dump_wdg module param
platform/x86: wmi: Remove debug_wmi module param
platform/x86: dell-smbios-wmi: Stop using WMI chardev
platform/x86: wmi: Remove chardev interface
platform/x86: wmi: Add driver development guide
.../wmi/driver-development-guide.rst | 126 ++++++++
Documentation/wmi/index.rst | 1 +
drivers/platform/x86/dell/dell-smbios-wmi.c | 163 +++++++---
drivers/platform/x86/wmi.c | 285 +-----------------
include/linux/wmi.h | 8 -
5 files changed, 256 insertions(+), 327 deletions(-)
create mode 100644 Documentation/wmi/driver-development-guide.rst
--
2.39.2
next reply other threads:[~2023-12-07 22:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 22:26 Armin Wolf [this message]
2023-12-07 22:26 ` [PATCH 1/5] platform/x86: wmi: Remove debug_dump_wdg module param Armin Wolf
2023-12-08 11:30 ` Ilpo Järvinen
2023-12-07 22:26 ` [PATCH 2/5] platform/x86: wmi: Remove debug_event " Armin Wolf
2023-12-08 11:33 ` Ilpo Järvinen
2023-12-07 22:26 ` [PATCH 3/5] platform/x86: dell-smbios-wmi: Stop using WMI chardev Armin Wolf
2023-12-08 13:41 ` Ilpo Järvinen
2023-12-08 18:00 ` Armin Wolf
2023-12-07 22:26 ` [PATCH 4/5] platform/x86: wmi: Remove chardev interface Armin Wolf
2023-12-08 13:43 ` Ilpo Järvinen
2023-12-07 22:26 ` [PATCH 5/5] platform/x86: wmi: Add driver development guide Armin Wolf
2023-12-08 12:25 ` Ilpo Järvinen
2023-12-08 18:10 ` Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207222623.232074-1-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=Dell.Client.Kernel@dell.com \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®