From: Conor Dooley <conor.dooley@microchip.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>,
<duje.mihanovic@skole.hr>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: mmp: pxa168: Fix memory leak in pxa168_clk_init()
Date: Mon, 11 Dec 2023 13:19:17 +0000 [thread overview]
Message-ID: <20231211-urgent-carol-45ca352a9d2a@wendy> (raw)
In-Reply-To: <20231210175232.3414584-1-visitorckw@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]
On Mon, Dec 11, 2023 at 01:52:32AM +0800, Kuan-Wei Chiu wrote:
> In cases where mapping of mpmu/apmu/apbc registers fails, the code path
> does not handle the failure gracefully, potentially leading to a memory
> leak. This fix ensures proper cleanup by freeing the allocated memory
> for 'pxa_unit' before returning.
>
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
I dunno why you have CCed me on this tbh, I guess I must have acked a
patch related to this driver's bindings somehow.
I wonder, is there actually any point in freeing these, isn't the system
going to fail to actually boot if these allocations fail?
> ---
> drivers/clk/mmp/clk-of-pxa168.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/mmp/clk-of-pxa168.c b/drivers/clk/mmp/clk-of-pxa168.c
> index fb0df64cf053..c5a7ba1deaa3 100644
> --- a/drivers/clk/mmp/clk-of-pxa168.c
> +++ b/drivers/clk/mmp/clk-of-pxa168.c
> @@ -308,18 +308,21 @@ static void __init pxa168_clk_init(struct device_node *np)
> pxa_unit->mpmu_base = of_iomap(np, 0);
> if (!pxa_unit->mpmu_base) {
> pr_err("failed to map mpmu registers\n");
> + kfree(pxa_unit);
> return;
> }
>
> pxa_unit->apmu_base = of_iomap(np, 1);
> if (!pxa_unit->apmu_base) {
> pr_err("failed to map apmu registers\n");
> + kfree(pxa_unit);
> return;
> }
>
> pxa_unit->apbc_base = of_iomap(np, 2);
> if (!pxa_unit->apbc_base) {
> pr_err("failed to map apbc registers\n");
> + kfree(pxa_unit);
> return;
> }
>
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-11 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 17:52 Kuan-Wei Chiu
2023-12-11 13:19 ` Conor Dooley [this message]
2023-12-12 5:13 ` Kuan-Wei Chiu
2023-12-17 1:15 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211-urgent-carol-45ca352a9d2a@wendy \
--to=conor.dooley@microchip.com \
--cc=duje.mihanovic@skole.hr \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®