From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB5BC10F05 for ; Mon, 11 Dec 2023 13:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343629AbjLKN5S (ORCPT ); Mon, 11 Dec 2023 08:57:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343823AbjLKN4Y (ORCPT ); Mon, 11 Dec 2023 08:56:24 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA5543A94 for ; Mon, 11 Dec 2023 05:55:00 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 761E2C433CB; Mon, 11 Dec 2023 13:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702302900; bh=o8O+wK3k8iq3mp06l66b2wBRTbIE05gE6n3hWpN4HHA=; h=From:To:Cc:Subject:Date:From; b=UO5SYE8h4lPBAMSaxVdw7qSB/COQDycUJVW/g2XO86fF8KH3Egh81BaDCxABIM8db NNkkLIh3IBh+50SnfSnZ2/6EX7i30Ix8GINrfEQl2eI7K/bdsGGlpP74ncMv8i9RRf 6gROZeWHUm/5ikZ5kGsKvuQR8BqnwA+dsp72ZRYOAIikF3FRiOtOF3yCqEEc2TQkz/ QeonUBChvBTejDj53q0ukZcM+scqaR7A8/l2kTdobz1OOcOKN8nOMlFvYV7pK7bSLG 1BwVvfP/o8LK6qB39QtL6AsroNj5neyxQ3+/dTbj2TPG6uE7qR/CpHniNQtd8QN4zq wuHYjW/5WvH4g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yicong Yang , Jonathan Cameron , Suzuki K Poulose , Sasha Levin , jonathan.cameron@huawei.com, alexander.shishkin@linux.intel.com Subject: [PATCH AUTOSEL 6.1 01/29] hwtracing: hisi_ptt: Handle the interrupt in hardirq context Date: Mon, 11 Dec 2023 08:53:45 -0500 Message-ID: <20231211135457.381397-1-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.66 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yicong Yang [ Upstream commit e0dd27ad8af00f147ac3c9de88e0687986afc3ea ] Handle the trace interrupt in the hardirq context, make sure the irq core won't threaded it by declaring IRQF_NO_THREAD and userspace won't balance it by declaring IRQF_NOBALANCING. Otherwise we may violate the synchronization requirements of the perf core, referenced to the change of arm-ccn PMU commit 0811ef7e2f54 ("bus: arm-ccn: fix PMU interrupt flags"). In the interrupt handler we mainly doing 2 things: - Copy the data from the local DMA buffer to the AUX buffer - Commit the data in the AUX buffer Signed-off-by: Yicong Yang Acked-by: Jonathan Cameron [ Fixed commit description to suppress checkpatch warning ] Signed-off-by: Suzuki K Poulose Link: https://lore.kernel.org/r/20231010084731.30450-3-yangyicong@huawei.com Signed-off-by: Sasha Levin --- drivers/hwtracing/ptt/hisi_ptt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c index 4140efd664097..75a8f24fdafee 100644 --- a/drivers/hwtracing/ptt/hisi_ptt.c +++ b/drivers/hwtracing/ptt/hisi_ptt.c @@ -342,9 +342,9 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt) return ret; hisi_ptt->trace_irq = pci_irq_vector(pdev, HISI_PTT_TRACE_DMA_IRQ); - ret = devm_request_threaded_irq(&pdev->dev, hisi_ptt->trace_irq, - NULL, hisi_ptt_isr, 0, - DRV_NAME, hisi_ptt); + ret = devm_request_irq(&pdev->dev, hisi_ptt->trace_irq, hisi_ptt_isr, + IRQF_NOBALANCING | IRQF_NO_THREAD, DRV_NAME, + hisi_ptt); if (ret) { pci_err(pdev, "failed to request irq %d, ret = %d\n", hisi_ptt->trace_irq, ret); -- 2.42.0