From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Lijo Lazar <lijo.lazar@amd.com>,
Hawking Zhang <Hawking.Zhang@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Sasha Levin <sashal@kernel.org>,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, le.ma@amd.com, James.Zhu@amd.com,
shane.xiao@amd.com, sonny.jiang@amd.com, Likun.Gao@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 6.1 25/29] drm/amdgpu: Add NULL checks for function pointers
Date: Mon, 11 Dec 2023 08:54:09 -0500 [thread overview]
Message-ID: <20231211135457.381397-25-sashal@kernel.org> (raw)
In-Reply-To: <20231211135457.381397-1-sashal@kernel.org>
From: Lijo Lazar <lijo.lazar@amd.com>
[ Upstream commit 81577503efb49f4ad76af22f9941d72900ef4aab ]
Check if function is implemented before making the call.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index 2eddd7f6cd41e..811dd3ea63620 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -1411,9 +1411,11 @@ static void soc15_common_get_clockgating_state(void *handle, u64 *flags)
if (amdgpu_sriov_vf(adev))
*flags = 0;
- adev->nbio.funcs->get_clockgating_state(adev, flags);
+ if (adev->nbio.funcs && adev->nbio.funcs->get_clockgating_state)
+ adev->nbio.funcs->get_clockgating_state(adev, flags);
- adev->hdp.funcs->get_clock_gating_state(adev, flags);
+ if (adev->hdp.funcs && adev->hdp.funcs->get_clock_gating_state)
+ adev->hdp.funcs->get_clock_gating_state(adev, flags);
if (adev->ip_versions[MP0_HWIP][0] != IP_VERSION(13, 0, 2)) {
@@ -1429,9 +1431,11 @@ static void soc15_common_get_clockgating_state(void *handle, u64 *flags)
}
/* AMD_CG_SUPPORT_ROM_MGCG */
- adev->smuio.funcs->get_clock_gating_state(adev, flags);
+ if (adev->smuio.funcs && adev->smuio.funcs->get_clock_gating_state)
+ adev->smuio.funcs->get_clock_gating_state(adev, flags);
- adev->df.funcs->get_clockgating_state(adev, flags);
+ if (adev->df.funcs && adev->df.funcs->get_clockgating_state)
+ adev->df.funcs->get_clockgating_state(adev, flags);
}
static int soc15_common_set_powergating_state(void *handle,
--
2.42.0
next prev parent reply other threads:[~2023-12-11 13:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 13:53 [PATCH AUTOSEL 6.1 01/29] hwtracing: hisi_ptt: Handle the interrupt in hardirq context Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 02/29] hwtracing: hisi_ptt: Don't try to attach a task Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 03/29] ASoC: wm8974: Correct boost mixer inputs Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 04/29] arm64: dts: rockchip: fix rk356x pcie msg interrupt name Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 05/29] ASoC: Intel: Skylake: Fix mem leak in few functions Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 06/29] ASoC: nau8822: Fix incorrect type in assignment and cast to restricted __be16 Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 07/29] ASoC: Intel: Skylake: mem leak in skl register function Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 08/29] ASoC: cs43130: Fix the position of const qualifier Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 09/29] ASoC: cs43130: Fix incorrect frame delay configuration Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 10/29] ASoC: rt5650: add mutex to avoid the jack detection failure Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 11/29] ASoC: SOF: mediatek: mt8186: Add Google Steelix topology compatible Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 12/29] ASoC: Intel: skl_hda_dsp_generic: Drop HDMI routes when HDMI is not available Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 13/29] nouveau/tu102: flush all pdbs on vmm flush Sasha Levin
2023-12-11 14:10 ` Timur Tabi
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 14/29] ASoC: amd: yc: Add DMI entry to support System76 Pangolin 13 Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 15/29] ASoC: hdac_hda: Conditionally register dais for HDMI and Analog Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 16/29] net/tg3: fix race condition in tg3_reset_task() Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 17/29] ASoC: da7219: Support low DC impedance headset Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 18/29] ASoC: ops: add correct range check for limiting volume Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 19/29] nvme: introduce helper function to get ctrl state Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 20/29] nvme: prevent potential spectre v1 gadget Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 21/29] arm64: dts: rockchip: Fix PCI node addresses on rk3399-gru Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 22/29] mips/smp: Call rcutree_report_cpu_starting() earlier Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 23/29] drm/amd/display: Use channel_width = 2 for vram table 3.0 Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 24/29] drm/amd/display: Add monitor patch for specific eDP Sasha Levin
2023-12-11 13:54 ` Sasha Levin [this message]
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 26/29] drm/exynos: fix a potential error pointer dereference Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 27/29] drm/exynos: fix a wrong error checking Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 28/29] hwmon: (corsair-psu) Fix probe when built-in Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 29/29] LoongArch: Preserve syscall nr across execve() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211135457.381397-25-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Hawking.Zhang@amd.com \
--cc=James.Zhu@amd.com \
--cc=Likun.Gao@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=le.ma@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shane.xiao@amd.com \
--cc=sonny.jiang@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®