From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C2C7C4167B for ; Mon, 11 Dec 2023 14:06:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234810AbjLKOGf (ORCPT ); Mon, 11 Dec 2023 09:06:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344135AbjLKOF2 (ORCPT ); Mon, 11 Dec 2023 09:05:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCFAB44BA for ; Mon, 11 Dec 2023 06:03:22 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1290DC433C8; Mon, 11 Dec 2023 14:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702303402; bh=55IWi7q/c+xuk9m4sVnI8Kz2vIQE5t0toHxv97SDJPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DKNyHxF5vxGsKeVNkXbvEBYlQ00ah88OIApFAJvyTD+qohhND8Y/A24OTNUxrkam6 zkoaVG8F5RvTxpIY0sWrHp+qlenBlyhFPsRfAZJ2soOQ6rvuODdEFQh8H7CwAHzUPU UvAgGfwILKJDZx6xe6yIZdoFbeeOkegSqY+a07XsG+7cWDbesAkSXf2uXIYEcYWzuw xk+BgSa1VmFzetV6m8L26p66oXkQmy1a2UVDoeQfCjd4Fp6c/N2KGqFxZKcmedpFcD zHA75qwRDqpaIuxZKXeezt4NXsg0Lwj7DqLFsIw40d9FKmmFWp+9uyDZlnkvI9GMay CGieNieVSmG/A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xiang Yang , Inki Dae , Sasha Levin , sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 5/5] drm/exynos: fix a potential error pointer dereference Date: Mon, 11 Dec 2023 09:03:10 -0500 Message-ID: <20231211140311.392827-5-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231211140311.392827-1-sashal@kernel.org> References: <20231211140311.392827-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.332 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiang Yang [ Upstream commit 73bf1c9ae6c054c53b8e84452c5e46f86dd28246 ] Smatch reports the warning below: drivers/gpu/drm/exynos/exynos_hdmi.c:1864 hdmi_bind() error: 'crtc' dereferencing possible ERR_PTR() The return value of exynos_drm_crtc_get_by_type maybe ERR_PTR(-ENODEV), which can not be used directly. Fix this by checking the return value before using it. Signed-off-by: Xiang Yang Signed-off-by: Inki Dae Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 0109ff40b1db2..3d79a7af8c862 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1722,6 +1722,8 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data) return ret; crtc = exynos_drm_crtc_get_by_type(drm_dev, EXYNOS_DISPLAY_TYPE_HDMI); + if (IS_ERR(crtc)) + return PTR_ERR(crtc); crtc->pipe_clk = &hdata->phy_clk; ret = hdmi_create_connector(encoder); -- 2.42.0