From: Francesco Dolcini <francesco@dolcini.it>
To: Amitkumar Karwar <amitkumar.karwar@nxp.com>,
Neeraj Kale <neeraj.sanjaykale@nxp.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: [PATCH v2 3/3] Bluetooth: btnxpuart: remove useless assignment
Date: Mon, 11 Dec 2023 17:40:20 +0100 [thread overview]
Message-ID: <20231211164020.173253-4-francesco@dolcini.it> (raw)
In-Reply-To: <20231211164020.173253-1-francesco@dolcini.it>
From: Francesco Dolcini <francesco.dolcini@toradex.com>
Remove useless assignment of rx_skb to NULL in case the skb is in error,
this is already done in h4_recv_buf() that is executed a few lines
before.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
drivers/bluetooth/btnxpuart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 951fe3014a3f..b7c56be078f8 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1278,7 +1278,6 @@ static int btnxpuart_receive_buf(struct serdev_device *serdev, const u8 *data,
/* Safe to ignore out-of-sync bootloader signatures */
if (!is_fw_downloading(nxpdev))
bt_dev_err(nxpdev->hdev, "Frame reassembly failed (%d)", err);
- nxpdev->rx_skb = NULL;
return count;
}
if (!is_fw_downloading(nxpdev))
--
2.25.1
next prev parent reply other threads:[~2023-12-11 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 16:40 [PATCH v2 0/3] Bluetooth: fix recv_buf() return value Francesco Dolcini
2023-12-11 16:40 ` [PATCH v2 1/3] Bluetooth: btnxpuart: " Francesco Dolcini
2023-12-11 16:40 ` [PATCH v2 2/3] Bluetooth: btmtkuart: " Francesco Dolcini
2023-12-11 16:40 ` Francesco Dolcini [this message]
2023-12-12 16:20 ` [PATCH v2 0/3] Bluetooth: " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211164020.173253-4-francesco@dolcini.it \
--to=francesco@dolcini.it \
--cc=amitkumar.karwar@nxp.com \
--cc=francesco.dolcini@toradex.com \
--cc=jirislaby@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®