mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yury Norov <yury.norov@gmail.com>
To: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Daniel Mack <zonque@gmail.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Yury Norov <yury.norov@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	linux-sound@vger.kernel.org, alsa-devel@alsa-project.org
Cc: Jan Kara <jack@suse.cz>,
	Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
	Matthew Wilcox <willy@infradead.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
	Alexey Klimov <klimov.linux@gmail.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Sergey Shtylyov <s.shtylyov@omp.ru>, Takashi Iwai <tiwai@suse.de>
Subject: [PATCH v3 32/35] ALSA: use atomic find_bit() functions where applicable
Date: Mon, 11 Dec 2023 18:27:46 -0800	[thread overview]
Message-ID: <20231212022749.625238-33-yury.norov@gmail.com> (raw)
In-Reply-To: <20231212022749.625238-1-yury.norov@gmail.com>

ALSA code tests each bit in bitmaps in a for() loop. Switch it to
using dedicated atomic find_bit() API.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/hda_codec.c |  7 +++----
 sound/usb/caiaq/audio.c   | 13 +++++--------
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 01718b1fc9a7..29254005f394 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -3275,10 +3275,9 @@ static int get_empty_pcm_device(struct hda_bus *bus, unsigned int type)
 
 #ifdef CONFIG_SND_DYNAMIC_MINORS
 	/* non-fixed slots starting from 10 */
-	for (i = 10; i < 32; i++) {
-		if (!test_and_set_bit(i, bus->pcm_dev_bits))
-			return i;
-	}
+	i = find_and_set_next_bit(bus->pcm_dev_bits, 32, 10);
+	if (i < 32)
+		return i;
 #endif
 
 	dev_warn(bus->card->dev, "Too many %s devices\n",
diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c
index 4981753652a7..74dfcf32b439 100644
--- a/sound/usb/caiaq/audio.c
+++ b/sound/usb/caiaq/audio.c
@@ -610,7 +610,7 @@ static void read_completed(struct urb *urb)
 	struct snd_usb_caiaq_cb_info *info = urb->context;
 	struct snd_usb_caiaqdev *cdev;
 	struct device *dev;
-	struct urb *out = NULL;
+	struct urb *out;
 	int i, frame, len, send_it = 0, outframe = 0;
 	unsigned long flags;
 	size_t offset = 0;
@@ -625,17 +625,14 @@ static void read_completed(struct urb *urb)
 		return;
 
 	/* find an unused output urb that is unused */
-	for (i = 0; i < N_URBS; i++)
-		if (test_and_set_bit(i, &cdev->outurb_active_mask) == 0) {
-			out = cdev->data_urbs_out[i];
-			break;
-		}
-
-	if (!out) {
+	i = find_and_set_bit(&cdev->outurb_active_mask, N_URBS);
+	if (i >= N_URBS) {
 		dev_err(dev, "Unable to find an output urb to use\n");
 		goto requeue;
 	}
 
+	out = cdev->data_urbs_out[i];
+
 	/* read the recently received packet and send back one which has
 	 * the same layout */
 	for (frame = 0; frame < FRAMES_PER_URB; frame++) {
-- 
2.40.1


  parent reply	other threads:[~2023-12-12  2:29 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  2:27 [PATCH v3 00/35] bitops: add atomic find_bit() operations Yury Norov
2023-12-12  2:27 ` [PATCH v3 01/35] lib/find: add atomic find_bit() primitives Yury Norov
2023-12-12  2:27 ` [PATCH v3 02/35] lib/find: add test for atomic find_bit() ops Yury Norov
2023-12-12  2:27 ` [PATCH v3 03/35] lib/sbitmap; optimize __sbitmap_get_word() by using find_and_set_bit() Yury Norov
2023-12-12  2:27 ` [PATCH v3 04/35] watch_queue: optimize post_one_notification() by using find_and_clear_bit() Yury Norov
2023-12-12  2:27 ` [PATCH v3 05/35] sched: add cpumask_find_and_set() and use it in __mm_cid_get() Yury Norov
2023-12-12 14:14   ` Mathieu Desnoyers
2023-12-12  2:27 ` [PATCH v3 06/35] mips: sgi-ip30: optimize heart_alloc_int() by using find_and_set_bit() Yury Norov
2023-12-12  2:27 ` [PATCH v3 07/35] sparc: optimize alloc_msi() " Yury Norov
2023-12-12  2:27 ` [PATCH v3 08/35] perf/arm: use atomic find_bit() API Yury Norov
2023-12-12  2:27 ` [PATCH v3 09/35] drivers/perf: optimize ali_drw_get_counter_idx() by using find_and_set_bit() Yury Norov
2023-12-12  2:27 ` [PATCH v3 10/35] dmaengine: idxd: optimize perfmon_assign_event() Yury Norov
2023-12-12  2:30   ` Fenghua Yu
2023-12-12  2:27 ` [PATCH v3 11/35] ath10k: optimize ath10k_snoc_napi_poll() Yury Norov
2023-12-12  2:27 ` [PATCH v3 12/35] wifi: rtw88: optimize the driver by using atomic iterator Yury Norov
2023-12-12  2:27 ` [PATCH v3 13/35] KVM: x86: hyper-v: optimize and cleanup kvm_hv_process_stimers() Yury Norov
2023-12-12 17:22   ` Sean Christopherson
2023-12-12 17:35     ` Yury Norov
2023-12-12  2:27 ` [PATCH v3 14/35] PCI: hv: Optimize hv_get_dom_num() by using find_and_set_bit() Yury Norov
2023-12-12  2:27 ` [PATCH v3 15/35] scsi: core: optimize scsi_evt_emit() by using an atomic iterator Yury Norov
2023-12-12  2:27 ` [PATCH v3 16/35] scsi: mpi3mr: optimize the driver by using find_and_set_bit() Yury Norov
2023-12-12  2:27 ` [PATCH v3 17/35] scsi: qedi: optimize qedi_get_task_idx() " Yury Norov
2023-12-12  2:27 ` [PATCH v3 18/35] powerpc: optimize arch code by using atomic find_bit() API Yury Norov
2023-12-12  2:27 ` [PATCH v3 19/35] iommu: optimize subsystem " Yury Norov
2023-12-12  2:27 ` [PATCH v3 20/35] media: radio-shark: optimize the driver " Yury Norov
2023-12-12  2:27 ` [PATCH v3 21/35] sfc: " Yury Norov
2023-12-12  2:27 ` [PATCH v3 22/35] tty: nozomi: optimize interrupt_handler() Yury Norov
2023-12-12  2:27 ` [PATCH v3 23/35] usb: cdc-acm: optimize acm_softint() Yury Norov
2023-12-12  2:27 ` [PATCH v3 24/35] block: null_blk: replace get_tag() with a generic find_and_set_bit_lock() Yury Norov
2023-12-12  2:27 ` [PATCH v3 25/35] RDMA/rtrs: optimize __rtrs_get_permit() by using find_and_set_bit_lock() Yury Norov
2023-12-12  2:27 ` [PATCH v3 26/35] mISDN: optimize get_free_devid() Yury Norov
2023-12-12  2:27 ` [PATCH v3 27/35] media: em28xx: cx231xx: optimize drivers by using find_and_set_bit() Yury Norov
2023-12-12  2:27 ` [PATCH v3 28/35] ethernet: rocker: optimize ofdpa_port_internal_vlan_id_get() Yury Norov
2023-12-12  2:27 ` [PATCH v3 29/35] serial: sc12is7xx: optimize sc16is7xx_alloc_line() Yury Norov
2023-12-12  2:27 ` [PATCH v3 30/35] bluetooth: optimize cmtp_alloc_block_id() Yury Norov
2023-12-12  2:27 ` [PATCH v3 31/35] net: smc: optimize smc_wr_tx_get_free_slot_index() Yury Norov
2023-12-12 13:26   ` Wen Gu
2023-12-12  2:27 ` Yury Norov [this message]
2023-12-12  2:27 ` [PATCH v3 33/35] m68k: optimize get_mmu_context() Yury Norov
2023-12-12  2:27 ` [PATCH v3 34/35] microblaze: " Yury Norov
2023-12-12  2:27 ` [PATCH v3 35/35] sh: mach-x3proto: optimize ilsel_enable() Yury Norov
2023-12-16 21:48 ` [PATCH v3 00/35] bitops: add atomic find_bit() operations Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231212022749.625238-33-yury.norov@gmail.com \
    --to=yury.norov@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bvanassche@acm.org \
    --cc=cezary.rojewski@intel.com \
    --cc=jack@suse.cz \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=keescook@chromium.org \
    --cc=klimov.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=perex@perex.cz \
    --cc=s.shtylyov@omp.ru \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    --cc=willy@infradead.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®