From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Milian Wolff <milian.wolff@kdab.com>,
Pablo Galindo <pablogsal@gmail.com>,
Fangrui Song <maskray@google.com>
Subject: [PATCH 1/3] perf genelf: Set ELF program header addresses properly
Date: Mon, 11 Dec 2023 23:05:44 -0800 [thread overview]
Message-ID: <20231212070547.612536-2-namhyung@kernel.org> (raw)
In-Reply-To: <20231212070547.612536-1-namhyung@kernel.org>
The text section starts after the ELF headers so PHDR.p_vaddr and
others should have the correct addresses.
Fixes: babd04386b1d ("perf jit: Include program header in ELF files")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/genelf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
index fefc72066c4e..ac17a3cb59dc 100644
--- a/tools/perf/util/genelf.c
+++ b/tools/perf/util/genelf.c
@@ -293,9 +293,9 @@ jit_write_elf(int fd, uint64_t load_addr, const char *sym,
*/
phdr = elf_newphdr(e, 1);
phdr[0].p_type = PT_LOAD;
- phdr[0].p_offset = 0;
- phdr[0].p_vaddr = 0;
- phdr[0].p_paddr = 0;
+ phdr[0].p_offset = GEN_ELF_TEXT_OFFSET;
+ phdr[0].p_vaddr = GEN_ELF_TEXT_OFFSET;
+ phdr[0].p_paddr = GEN_ELF_TEXT_OFFSET;
phdr[0].p_filesz = csize;
phdr[0].p_memsz = csize;
phdr[0].p_flags = PF_X | PF_R;
--
2.43.0.472.g3155946c3a-goog
next prev parent reply other threads:[~2023-12-12 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 7:05 [PATCH 0/3] perf tools: Random fixes for DWARF unwind Namhyung Kim
2023-12-12 7:05 ` Namhyung Kim [this message]
2023-12-12 18:07 ` [PATCH 1/3] perf genelf: Set ELF program header addresses properly Ian Rogers
2023-12-12 7:05 ` [PATCH 2/3] perf unwind-libdw: Handle JIT-generated DSOs properly Namhyung Kim
2023-12-12 18:07 ` Ian Rogers
2023-12-13 22:13 ` Namhyung Kim
2023-12-12 7:05 ` [PATCH 3/3] perf unwind-libunwind: Fix base address for .eh_frame Namhyung Kim
2023-12-12 18:08 ` Ian Rogers
2023-12-12 18:10 ` [PATCH 0/3] perf tools: Random fixes for DWARF unwind Ian Rogers
2023-12-13 0:54 ` Pablo Galindo Salgado
2023-12-13 22:07 ` Namhyung Kim
2023-12-14 22:07 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212070547.612536-2-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maskray@google.com \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=pablogsal@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®