From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16480C4332F for ; Tue, 12 Dec 2023 16:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232372AbjLLQ1T (ORCPT ); Tue, 12 Dec 2023 11:27:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbjLLQ1R (ORCPT ); Tue, 12 Dec 2023 11:27:17 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AD99AD for ; Tue, 12 Dec 2023 08:27:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D207C433C7; Tue, 12 Dec 2023 16:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702398443; bh=t3KKiYi0IdU2y9j91oE71YEklgKddavq7ESsXn9uET4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FmrX47b7FO9QssAD09a7oHhvNJ1/DSXBvjQ4RvCYchuZ6/sTAh9XBDG970mIzERJp TTo902Q+yAcmPS1hPuve25ZZ4rI0Mz6S66LXqWrUYSqaoCxBkx6XcimchzuR06NnkM fS3Q/VztSu9++JBc+V14I/GMbW9RQyg439T3PihA= Date: Tue, 12 Dec 2023 08:27:22 -0800 From: Andrew Morton To: Ryan Roberts Cc: David Hildenbrand , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song Subject: Re: [PATCH v9 03/10] mm: thp: Introduce multi-size THP sysfs interface Message-Id: <20231212082722.13e857daf589bd49d5e877d9@linux-foundation.org> In-Reply-To: References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-4-ryan.roberts@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Dec 2023 15:32:29 +0000 Ryan Roberts wrote: > > Why not perform lock/unlock only once in surrounding code? :) > > I was nervous that sysfs_streq() may be unhappy in atomic context... Unfounded? > Yes, unfounded.