mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sanath S <Sanath.S@amd.com>
To: <mario.limonciello@amd.com>, <andreas.noever@gmail.com>,
	<michael.jamet@intel.com>, <mika.westerberg@linux.intel.com>,
	<YehezkelShB@gmail.com>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Sanath S <Sanath.S@amd.com>
Subject: [Patch v2 2/2] thunderbolt: Teardown tunnels and reset downstream ports created by boot firmware
Date: Wed, 13 Dec 2023 00:46:35 +0530	[thread overview]
Message-ID: <20231212191635.2022520-3-Sanath.S@amd.com> (raw)
In-Reply-To: <20231212191635.2022520-1-Sanath.S@amd.com>

Boot firmware might have created tunnels of its own. Since we cannot
be sure they are usable for us. Tear them down and reset the ports
to handle it as a new hotplug for USB3 routers.

Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Sanath S <Sanath.S@amd.com>
---
 drivers/thunderbolt/tb.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
index fd49f86e0353..febd0b6972e3 100644
--- a/drivers/thunderbolt/tb.c
+++ b/drivers/thunderbolt/tb.c
@@ -2598,6 +2598,17 @@ static int tb_start(struct tb *tb)
 	tb_switch_tmu_enable(tb->root_switch);
 	/* Full scan to discover devices added before the driver was loaded. */
 	tb_scan_switch(tb->root_switch);
+	/*
+	 * Boot firmware might have created tunnels of its own. Since we cannot
+	 * be sure they are usable for us, Tear them down and reset the ports
+	 * to handle it as new hotplug for USB4 routers.
+	 */
+	if (tb_switch_is_usb4(tb->root_switch)) {
+		tb_switch_discover_tunnels(tb->root_switch,
+					   &tcm->tunnel_list, false);
+		tcm->hotplug_active = true;
+		return tb_switch_reset_ports(tb->root_switch);
+	}
 	/* Find out tunnels created by the boot firmware */
 	tb_discover_tunnels(tb);
 	/* Add DP resources from the DP tunnels created by the boot firmware */
-- 
2.34.1


  parent reply	other threads:[~2023-12-12 19:17 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 19:16 [PATCH v2 0/2] Add support for downstream port reset(DPR) Sanath S
2023-12-12 19:16 ` [Patch v2 1/2] thunderbolt: Introduce tb_switch_reset_ports(), tb_port_reset() and usb4_port_reset() Sanath S
2023-12-12 19:26   ` Mario Limonciello
2023-12-13  5:59   ` Mika Westerberg
2023-12-13 11:58     ` Sanath S
2023-12-13 12:04       ` Mika Westerberg
2023-12-12 19:16 ` Sanath S [this message]
2023-12-12 19:24   ` [Patch v2 2/2] thunderbolt: Teardown tunnels and reset downstream ports created by boot firmware Mario Limonciello
2023-12-12 19:25     ` Mario Limonciello
2023-12-13  5:49   ` Mika Westerberg
2023-12-13  6:18     ` Mika Westerberg
2023-12-13  6:23       ` Mika Westerberg
2023-12-13 10:34         ` Sanath S
2023-12-13 11:52           ` Mika Westerberg
2023-12-14  6:38             ` Sanath S
2023-12-14  7:07               ` Mika Westerberg
2023-12-14  7:20                 ` Sanath S
2023-12-14  7:32                   ` Mika Westerberg
2023-12-14 15:30                     ` Sanath S
2023-12-15 11:55                       ` Mika Westerberg
2023-12-15 13:54                         ` Sanath S
2023-12-15 14:02                           ` Mika Westerberg
2023-12-18 10:20                             ` Sanath S
2023-12-18 10:42                               ` Mika Westerberg
2023-12-18 11:19                                 ` Sanath S
2023-12-18 11:31                                   ` Mika Westerberg
2023-12-18 12:23                                     ` Mika Westerberg
2023-12-18 13:05                                       ` Sanath S
2023-12-18 13:18                                         ` Mika Westerberg
2023-12-19  9:11                                           ` Sanath S
2023-12-19 12:26                                             ` Mika Westerberg
2023-12-19 14:35                                               ` Sanath S
2023-12-19 18:04                                                 ` Mika Westerberg
2023-12-20 12:58                                                   ` Mika Westerberg
2023-12-20 17:01                                                     ` Sanath S
2023-12-21  9:31                                                       ` Sanath S
2023-12-21  9:53                                                         ` Mika Westerberg
2024-01-03 14:15                                                           ` Sanath S
2024-01-03 17:17                                                             ` Mika Westerberg
2024-01-04 13:47                                                               ` Sanath S
2024-01-04 13:50                                                               ` Sanath S
2024-01-05  7:08                                                                 ` Mika Westerberg
2024-01-08  4:56                                                                   ` Sanath S
2024-01-10 14:32                                                                     ` Mika Westerberg
2024-01-04 16:49                                               ` Sanath S
2024-01-05  7:06                                                 ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231212191635.2022520-3-Sanath.S@amd.com \
    --to=sanath.s@amd.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®