From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3341C41535 for ; Wed, 13 Dec 2023 02:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378371AbjLMC6R convert rfc822-to-8bit (ORCPT ); Tue, 12 Dec 2023 21:58:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235216AbjLMC6O (ORCPT ); Tue, 12 Dec 2023 21:58:14 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62F9AB3; Tue, 12 Dec 2023 18:58:18 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 5C4C924E254; Wed, 13 Dec 2023 10:58:15 +0800 (CST) Received: from EXMBX072.cuchost.com (172.16.6.82) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 13 Dec 2023 10:58:15 +0800 Received: from localhost.localdomain (202.188.176.82) by EXMBX072.cuchost.com (172.16.6.82) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 13 Dec 2023 10:58:11 +0800 From: Ji Sheng Teoh To: CC: , , , , , , , , , , , Subject: Re: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100 Date: Wed, 13 Dec 2023 10:57:59 +0800 Message-ID: <20231213025759.812453-1-jisheng.teoh@starfivetech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231212-shout-bazooka-714aeda42ec1@spud> References: <20231212-shout-bazooka-714aeda42ec1@spud> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [202.188.176.82] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX072.cuchost.com (172.16.6.82) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Dec 2023 16:47:59 +0000 Conor Dooley wrote: > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote: > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote: > > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100 > > > watchdog. > > > Since JH8100 watchdog only has 1 reset signal, update binding > > > document to support one reset for "starfive,jh8100-wdt" > > > compatible. > > > > > > Signed-off-by: Ley Foon Tan > > > Signed-off-by: Ji Sheng Teoh > > > --- > > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > | 2 ++ 1 file changed, 2 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > index 68f3f6fd08a6..02572b16ac08 100644 --- > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > +++ > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml > > > @@ -27,6 +27,7 @@ properties: enum: > > > - starfive,jh7100-wdt > > > - starfive,jh7110-wdt > > > + - starfive,jh8100-wdt > > > > > > reg: > > > maxItems: 1 > > > @@ -45,6 +46,7 @@ properties: > > > - const: core > > > > > > resets: > > > + minItems: 1 > > > items: > > > - description: APB reset > > > - description: Core reset > > > > This relaxes the constraints for the existing devices, please add > > per compatible constraints to avoid doing so. > Thanks Conor. Just to clarify, are you suggesting to add what was done in v1? v1: https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/ > Also, you do not appear to have implemented the request from Krzysztof > to express compatibility with the jh7110. > Ok, fix that up.