From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F947C4332F for ; Wed, 13 Dec 2023 16:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235470AbjLMQOI (ORCPT ); Wed, 13 Dec 2023 11:14:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235223AbjLMQNv (ORCPT ); Wed, 13 Dec 2023 11:13:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D32E0B9 for ; Wed, 13 Dec 2023 08:13:56 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63BF1C433C8; Wed, 13 Dec 2023 16:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702484036; bh=qrD0MrsY/L+ptpyJGJ+B+8mNoxKA92VdRp7Ypgf5fYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f2Y/VWIUrFnciX2ebT4ABNR8Osjl7qn5YgrItr8tv5vMeIikgDgkpPW6nFZagRniS XGUs6B5SL/B4sU2eRQM+tf1Y3YTUIPdQyIfeNAnw9kOp7+00GArd7aNY6e1KXasDmL cAs8L8NOy9/K5gmzfS60qGg5khi4gJtqUBs3guwdQHdEgfvX5IyuJTtiLrTJWJLQmH Zq+zI6KvT+0BHJ7W1rZOOugcmjObEzgpyFGWJ3vsg5IYNexoRWyAJDEvUi0PfqONkS 1x/aKwzDIDGpKEBt2KuLYTbKfLSvyqoIokb9I1dFwgv3wsUNXrR5xT/pvV7+WEt0f+ 8Mhx8enV1AvqQ== Date: Wed, 13 Dec 2023 16:13:52 +0000 From: Lee Jones To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Alex Vinarskis Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider flags Message-ID: <20231213161352.GQ111411@google.com> References: <20231211111441.3910083-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231211111441.3910083-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Dec 2023, Andy Shevchenko wrote: > The conversion to CLK_FRAC_DIVIDER_POWER_OF_TWO_PS uses wrong flags > in the parameters and hence miscalculates the values in the clock > divider. Fix this by applying the flag to the proper parameter. > > Fixes: 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag") > Reported-by: Alex Vinarskis > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel-lpss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c > index 177915845ba2..eff423f7dd28 100644 > --- a/drivers/mfd/intel-lpss.c > +++ b/drivers/mfd/intel-lpss.c > @@ -309,8 +309,8 @@ static int intel_lpss_register_clock_divider(struct intel_lpss *lpss, > > snprintf(name, sizeof(name), "%s-div", devname); > tmp = clk_register_fractional_divider(NULL, name, __clk_get_name(tmp), > + 0, lpss->priv, 1, 15, 16, 15, > CLK_FRAC_DIVIDER_POWER_OF_TWO_PS, > - lpss->priv, 1, 15, 16, 15, 0, > NULL); What an ugly interface. Intel-only too, right? Have you also fixed this in: drivers/acpi/acpi_lpss.c > if (IS_ERR(tmp)) > return PTR_ERR(tmp); > -- > 2.43.0.rc1.1.gbec44491f096 > -- Lee Jones [李琼斯]