From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60683671E8 for ; Thu, 14 Dec 2023 22:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WX7H+Zrw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F662C433C8; Thu, 14 Dec 2023 22:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702592222; bh=2D9nG2KNudL+10rZMcKkKt/VtIVyh9wWPQJtsj2OmR8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WX7H+ZrwBVrU3L1JS5De2zQh+c0BePlKvIWJc5LefMj36TYdyIPyIw3K38DgoEEWG jYwV2WvZdxeUat7eT0WhN8zQgD6v9xD/u3ern3xb7nSLxsDB09A3d7PKyyJPtJBmVA S4g5xo9qcSqYFX6zN/b7RpYjvP7M4VPQ73X3aRZc= Date: Thu, 14 Dec 2023 14:17:01 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: Mel Gorman , baolin.wang@linux.alibaba.com, linux-mm@kvack.org, david@redhat.com, hannes@cmpxchg.org, huzhanyuan@oppo.com, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com, v-songbaohua@oppo.com, willy@infradead.org Subject: Re: [PATCH] mm: compaction: avoid fast_isolate_freepages blindly choose improper pageblock Message-Id: <20231214141701.29aef9815d3e743645786c1e@linux-foundation.org> In-Reply-To: References: <20231206110054.61617-1-v-songbaohua@oppo.com> <20231213130231.ksban2ovad4q4rxj@techsingularity.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Thu, 14 Dec 2023 09:34:35 +0800 Barry Song <21cnbao@gmail.com> wrote: > > > Reported-by: Zhanyuan Hu > > > Signed-off-by: Barry Song > > > > Acked-by: Mel Gorman > > Hi Mel, > Thanks! > > Hi Andrew, > Given this patch has been in mm-stable, > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-stable&id=d19b1a1797 > does it still have a chance to collect Mel's tag? That would require a rebuild of mm-stable, which is also a rebase. I don't think I've had to do that before - I'll occasionally rebase, but just to drop things - not a full rebuild from the quilt patches. If I end up having to do that then I'll somehow try to remember to make this change.