From: Dragos Tatulea <dtatulea@nvidia.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Eugenio Perez Martin <eperezma@redhat.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
<virtualization@lists.linux-foundation.org>,
Gal Pressman <gal@nvidia.com>
Cc: Dragos Tatulea <dtatulea@nvidia.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Parav Pandit <parav@nvidia.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [PATCH vhost v3 0/6] vdpa/mlx5: Add support for resumable vqs
Date: Fri, 15 Dec 2023 16:01:40 +0200 [thread overview]
Message-ID: <20231215140146.95816-1-dtatulea@nvidia.com> (raw)
Add support for resumable vqs in the driver. This is a firmware feature
that can be used for the following benefits:
- Full device .suspend/.resume.
- .set_map doesn't need to destroy and create new vqs anymore just to
update the map. When resumable vqs are supported it is enough to
suspend the vqs, set the new maps, and then resume the vqs.
The first patch exposes the relevant bits in mlx5_ifc.h. That means it
needs to be applied to the mlx5-vhost tree [0] first. Once applied
there, the change has to be pulled from mlx5-vhost into the vhost tree
and only then the remaining patches can be applied. Same flow as the vq
descriptor mappings patchset [1].
The second part adds support for resumable vqs in the form of a device .resume
operation but also for the .set_map call (suspend/resume device instead
of re-creating vqs with new mappings).
The last part of the series introduces reference counting for mrs which
is necessary to avoid freeing mkeys too early or leaking them.
* Changes in v3:
- Dropped patches that allowed vq modification of state and addresses
when state is DRIVER_OK. This is not allowed by the standard.
Should be re-added under a vdpa feature flag.
* Changes in v2:
- Added mr refcounting patches.
- Deleted unnecessary patch: "vdpa/mlx5: Split function into locked and
unlocked variants"
- Small print improvement in "Introduce per vq and device resume"
patch.
- Patch 1/7 has been applied to mlx5-vhost branch.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-vhost
[1] https://lore.kernel.org/virtualization/20231018171456.1624030-2-dtatulea@nvidia.com/
Dragos Tatulea (6):
vdpa/mlx5: Expose resumable vq capability
vdpa/mlx5: Allow modifying multiple vq fields in one modify command
vdpa/mlx5: Introduce per vq and device resume
vdpa/mlx5: Use vq suspend/resume during .set_map
vdpa/mlx5: Introduce reference counting to mrs
vdpa/mlx5: Add mkey leak detection
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 10 +-
drivers/vdpa/mlx5/core/mr.c | 69 +++++++---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 194 +++++++++++++++++++++++++----
include/linux/mlx5/mlx5_ifc.h | 3 +-
include/linux/mlx5/mlx5_ifc_vdpa.h | 1 +
5 files changed, 239 insertions(+), 38 deletions(-)
--
2.43.0
next reply other threads:[~2023-12-15 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 14:01 Dragos Tatulea [this message]
2023-12-15 14:01 ` [PATCH mlx5-vhost v3 1/6] vdpa/mlx5: Expose resumable vq capability Dragos Tatulea
2023-12-15 14:01 ` [PATCH vhost v3 2/6] vdpa/mlx5: Allow modifying multiple vq fields in one modify command Dragos Tatulea
2023-12-15 14:01 ` [PATCH vhost v3 3/6] vdpa/mlx5: Introduce per vq and device resume Dragos Tatulea
2023-12-15 14:01 ` [PATCH vhost v3 4/6] vdpa/mlx5: Use vq suspend/resume during .set_map Dragos Tatulea
2023-12-15 14:01 ` [PATCH vhost v3 5/6] vdpa/mlx5: Introduce reference counting to mrs Dragos Tatulea
2023-12-15 14:01 ` [PATCH vhost v3 6/6] vdpa/mlx5: Add mkey leak detection Dragos Tatulea
2023-12-15 14:10 ` [PATCH vhost v3 0/6] vdpa/mlx5: Add support for resumable vqs Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215140146.95816-1-dtatulea@nvidia.com \
--to=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gal@nvidia.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®