From: attreyee-muk <tintinm2017@gmail.com>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch
Cc: attreyee-muk <tintinm2017@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/drm_gem.c: Fixed WARNING in drm_gem_object_handle_put_unlocked
Date: Sat, 16 Dec 2023 16:13:51 +0530 [thread overview]
Message-ID: <20231216104350.12375-1-tintinm2017@gmail.com> (raw)
Previously, I was sending out the patch in a wrong format, hence sending
this patch again describing my changes.
Looking at the code and the call trace reported by Syzbot (issue link : https://syzkaller.appspot.com/bug?extid=ef3256a360c02207a4cb), I understood
that the issue lies in the drm_gem.c file in
drm_gem_object_handle_put_unlocked(obj);.
As per my understanding, I believe that a warning is given out when the DRM GEM object handle gets
destroyed along with the function getting returned immediately.
To take care of the warning only, I think that the WARN_ON can be removed with
only the function getting returned when the object handle gets
destroyed, without a warning.
Or else, we can even have a message logging in the place of a direct warning which will give out the
information that the object handle has been destroyed.
I also think that the WARN_ON is given for debugging purposes and hence proposing a
solution if the warning can be replaced with a simple message log.
I am looking forward to getting help in this regard from the respected maintainers.
Thank You
Attreyee Mukherjee
Signed-off-by: Attreyee Mukherjee <tintinm2017@gmail.com>
---
drivers/gpu/drm/drm_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 44a948b80ee1..b6be9400cd11 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -222,7 +222,7 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
struct drm_device *dev = obj->dev;
bool final = false;
- if (WARN_ON(READ_ONCE(obj->handle_count) == 0))
+ if (READ_ONCE(obj->handle_count) == 0)
return;
/*
--
2.34.1
reply other threads:[~2023-12-16 11:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231216104350.12375-1-tintinm2017@gmail.com \
--to=tintinm2017@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®