mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ayush Singh <ayushdevel1325@gmail.com>
Cc: greybus-dev@lists.linaro.org, johan@kernel.org, elder@kernel.org,
	linux-kernel@vger.kernel.org, jkridner@beagleboard.org,
	nm@ti.com, yujie.liu@intel.com
Subject: Re: [PATCH V2 1/1] greybus: gb-beagleplay: Remove use of pad bytes
Date: Sat, 16 Dec 2023 08:19:51 +0100	[thread overview]
Message-ID: <2023121616-depict-unloving-525b@gregkh> (raw)
In-Reply-To: <e60f7697-1a1a-46a4-9def-b59cae9777a3@gmail.com>

On Sat, Dec 16, 2023 at 05:39:30AM +0530, Ayush Singh wrote:
> On 12/15/23 21:50, Greg KH wrote:
> 
> > On Mon, Dec 11, 2023 at 12:24:18PM +0530, Ayush Singh wrote:
> > > Make gb-beagleplay greybus spec compliant by moving cport information to
> > > transport layer instead of using `header->pad` bytes.
> > > 
> > > Greybus HDLC frame now has the following payload:
> > > 1. le16 cport
> > > 2. gb_operation_msg_hdr msg_header
> > > 3. u8 *msg_payload
> > > 
> > > Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver")
> > > Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
> > > ---
> > >   drivers/greybus/gb-beagleplay.c | 55 ++++++++++++++++++++++++---------
> > >   1 file changed, 41 insertions(+), 14 deletions(-)
> > This doesn't apply against my char-misc-next branch at all, what did you
> > generate it against?
> > 
> > thanks,
> > 
> > greg k-h
> 
> The base commit of my tree is `0f5f12ac05f36f117e793656c3f560625e927f1b`.
> The tag is `next-20231205`.
> 
> I can rebase to a newer tag if you wish.

Please rebase on the char-misc-next branch otherwise I can not take it.

thanks,

greg k-h

      reply	other threads:[~2023-12-16  7:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11  6:54 [PATCH V2 0/1] Make gb-beagleplay driver Greybus compliant Ayush Singh
2023-12-11  6:54 ` [PATCH V2 1/1] greybus: gb-beagleplay: Remove use of pad bytes Ayush Singh
2023-12-12 14:01   ` Alex Elder
2023-12-12 14:30     ` Ayush Singh
2023-12-15 16:20   ` Greg KH
2023-12-16  0:09     ` Ayush Singh
2023-12-16  7:19       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023121616-depict-unloving-525b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ayushdevel1325@gmail.com \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=jkridner@beagleboard.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=yujie.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®