From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v7 0/2] ring-buffer: Rename sub-buffer into buffer page
Date: Mon, 18 Dec 2023 11:28:17 -0500 [thread overview]
Message-ID: <20231218112817.7f3c8847@gandalf.local.home> (raw)
In-Reply-To: <20231218154618.954997-1-vdonnefort@google.com>
On Mon, 18 Dec 2023 15:46:18 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:
> Previously was introduced the ability to change the ring-buffer page
> size. It also introduced the concept of sub-buffer that is, a contiguous
> virtual memory space which can now be bigger than the system page size
> (4K on most systems). But behind the scene this is really just a page
> with an order > 0 and a struct buffer_page (often refered as "bpage")
> already exists. We have then an unnecessary duplicate subbuffer ==
> bpage.
>
> Remove all references to sub-buffer and replace them with either bpage
> or ring_buffer_page.
No! I think you misunderstood me before.
I want it the other way around. In Linux, "page" usually means the
architecture page (4096 on x86). If we are going to remove the duplicate of
subbuffer == bpage, remove the "page" part, *not* the subbuffer part. The
"subbuf" part is part of the design, not an implementation detail. The page
part, was just an implementation detail that we do not want to expose!
When you say "page" you mean a single page. If you say buffer_page_size,
one will think this is an architecture page, not the subbuffer size.
The ring buffer is broken up into subbuffers, The page is just an
implementation detail. Let's not confuse that with the design.
Thanks,
-- Steve
next prev parent reply other threads:[~2023-12-18 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:14 [PATCH v7 0/2] Introducing trace buffer mapping by user-space Vincent Donnefort
2023-12-18 15:14 ` [PATCH v7 1/2] ring-buffer: Introducing ring-buffer mapping functions Vincent Donnefort
2023-12-18 15:14 ` [PATCH v7 2/2] tracing: Allow user-space mapping of the ring-buffer Vincent Donnefort
2023-12-18 15:46 ` [PATCH v7 0/2] ring-buffer: Rename sub-buffer into buffer page Vincent Donnefort
2023-12-18 16:28 ` Steven Rostedt [this message]
2023-12-18 16:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218112817.7f3c8847@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®