From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4436D71459; Mon, 18 Dec 2023 12:45:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T8sqtap5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0500AC433CB; Mon, 18 Dec 2023 12:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702903535; bh=Xdi9ODgbTlGCteMm1KwfDu9VCAjH4Hpq0lQ44eD0cwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T8sqtap5cQEWX0Ol9bPlLnKBwzP0YnLukgsg1CrMyyqNSKMViVfijQZWcanLAyFAd FEwaf+IjUGBgHe2ywWYWxTa37TnzGVGQVCkVzeU/Phn1xe0Z8oetgMLlqlzNGd+P4a OvuTJL3yoJNdCph7+KZfjyC6AC+2VrCztdf1M/aD1cOjv5whfeAtprHeq54ZysMDwD JM5+CitgNLXPXPEbuwOvszlTAG0rm55x+gHPyS4eDXIiGyFVXlmn8tp2Z2Vk+B2PFp D/K1ConTKgpRgglvEav2R/apSO+4ia/4zFBZGt4IbjNRlKClbJ6yW8Jnq5NsNbw3Zs Ozo1xXlLxxcZQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Krzysztof Kozlowski , Yanteng Si , Conor Dooley , Jiaxun Yang , "David S . Miller" , Sasha Levin , alexandre.torgue@foss.st.com, joabreu@synopsys.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 12/15] stmmac: dwmac-loongson: drop useless check for compatible fallback Date: Mon, 18 Dec 2023 07:44:59 -0500 Message-ID: <20231218124513.1380056-12-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231218124513.1380056-1-sashal@kernel.org> References: <20231218124513.1380056-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.68 Content-Transfer-Encoding: 8bit From: Krzysztof Kozlowski [ Upstream commit 31fea092c6f9f8fb2c40a08137907f5fbeae55dd ] Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, so checking for some other compatible does not make sense. It cannot be bound to unsupported platform. Drop useless, incorrect (space in between) and undocumented compatible. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Yanteng Si Reviewed-by: Conor Dooley Acked-by: Jiaxun Yang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index a25c187d31853..900972521b599 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -59,11 +59,6 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id return -ENODEV; } - if (!of_device_is_compatible(np, "loongson, pci-gmac")) { - pr_info("dwmac_loongson_pci: Incompatible OF node\n"); - return -ENODEV; - } - plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL); if (!plat) return -ENOMEM; -- 2.43.0