From: kernel test robot <lkp@intel.com>
To: Kalle Valo <quic_kvalo@quicinc.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Balamurugan Selvarajan <quic_bselvara@quicinc.com>,
Baochen Qiang <quic_bqiang@quicinc.com>,
Bhagavathi Perumal S <quic_bperumal@quicinc.com>,
Carl Huang <quic_cjhuang@quicinc.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
P Praneesh <quic_ppranees@quicinc.com>,
Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>,
Ramya Gnanasekar <quic_rgnanase@quicinc.com>,
Sriram R <quic_srirrama@quicinc.com>,
Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
Wen Gong <quic_wgong@quicinc.com>
Subject: drivers/net/wireless/ath/ath12k/dp_mon.c:1244:24-34: Unneeded variable: "hal_status". Return " HAL_RX_MON_STATUS_BUF_DONE" on line 1260
Date: Tue, 19 Dec 2023 00:06:22 +0800 [thread overview]
Message-ID: <202312182311.pZjA9dgQ-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ceb6a6f023fd3e8b07761ed900352ef574010bcb
commit: d889913205cf7ebda905b1e62c5867ed4e39f6c2 wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices
date: 1 year, 1 month ago
config: csky-randconfig-r053-20231218 (https://download.01.org/0day-ci/archive/20231218/202312182311.pZjA9dgQ-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312182311.pZjA9dgQ-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/net/wireless/ath/ath12k/dp_mon.c:1244:24-34: Unneeded variable: "hal_status". Return " HAL_RX_MON_STATUS_BUF_DONE" on line 1260
--
>> drivers/net/wireless/ath/ath12k/dp_rx.c:3866:3-6: ERROR: invalid reference to the index variable of the iterator on line 3856
drivers/net/wireless/ath/ath12k/dp_rx.c:3866:29-32: ERROR: invalid reference to the index variable of the iterator on line 3856
--
>> drivers/net/wireless/ath/ath12k/wmi.c:6517:30-35: ERROR: invalid reference to the index variable of the iterator on line 6499
vim +1244 drivers/net/wireless/ath/ath12k/dp_mon.c
1231
1232 enum hal_rx_mon_status
1233 ath12k_dp_mon_rx_parse_mon_status(struct ath12k *ar,
1234 struct ath12k_mon_data *pmon,
1235 int mac_id,
1236 struct sk_buff *skb,
1237 struct napi_struct *napi)
1238 {
1239 struct ath12k_base *ab = ar->ab;
1240 struct hal_rx_mon_ppdu_info *ppdu_info = &pmon->mon_ppdu_info;
1241 struct dp_mon_mpdu *tmp;
1242 struct dp_mon_mpdu *mon_mpdu = pmon->mon_mpdu;
1243 struct sk_buff *head_msdu, *tail_msdu;
> 1244 enum hal_rx_mon_status hal_status = HAL_RX_MON_STATUS_BUF_DONE;
1245
1246 ath12k_dp_mon_parse_rx_dest(ab, pmon, skb);
1247
1248 list_for_each_entry_safe(mon_mpdu, tmp, &pmon->dp_rx_mon_mpdu_list, list) {
1249 list_del(&mon_mpdu->list);
1250 head_msdu = mon_mpdu->head;
1251 tail_msdu = mon_mpdu->tail;
1252
1253 if (head_msdu && tail_msdu) {
1254 ath12k_dp_mon_rx_deliver(ar, mac_id, head_msdu,
1255 ppdu_info, napi);
1256 }
1257
1258 kfree(mon_mpdu);
1259 }
> 1260 return hal_status;
1261 }
1262
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-18 16:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312182311.pZjA9dgQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_bperumal@quicinc.com \
--cc=quic_bqiang@quicinc.com \
--cc=quic_bselvara@quicinc.com \
--cc=quic_cjhuang@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_kvalo@quicinc.com \
--cc=quic_periyasa@quicinc.com \
--cc=quic_ppranees@quicinc.com \
--cc=quic_pradeepc@quicinc.com \
--cc=quic_rgnanase@quicinc.com \
--cc=quic_srirrama@quicinc.com \
--cc=quic_vthiagar@quicinc.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®