mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tanzir Hasan <tanzirh@google.com>
Cc: Kees Cook <keescook@chromium.org>,
	Nick DeSaulniers <nnn@google.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	llvm@lists.linux.dev
Subject: Re: [PATCH v4 2/2] lib/string: shrink lib/string.i via IWYU
Date: Tue, 19 Dec 2023 19:24:24 +0100	[thread overview]
Message-ID: <2023121926-mummy-gondola-0a56@gregkh> (raw)
In-Reply-To: <20231219-libstringheader-v4-2-aaeb26495d2f@google.com>

On Tue, Dec 19, 2023 at 06:09:52PM +0000, Tanzir Hasan wrote:
> This diff uses an open source tool include-what-you-use (IWYU) to modify
> the include list changing indirect includes to direct includes.
> IWYU is implemented using the IWYUScripts github repository which is a tool that is
> currently undergoing development. These changes seek to improve build times.
> 
> This change to lib/string.c resulted in a preprocessed size of
> lib/string.i from 26371 lines to 5321 lines (-80%) for the x86
> defconfig.

Nit, use 72 columns like your editor is trying to force on you when you
write a git commit.  As is, these line-ends are all over the place.

It's the stuff around the actual change that is hard to get right...

thanks,

greg k-h

      reply	other threads:[~2023-12-19 18:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 18:09 [PATCH v4 0/2] " Tanzir Hasan
2023-12-19 18:09 ` [PATCH v4 1/2] kernel.h: removed REPEAT_BYTE from kernel.h Tanzir Hasan
2023-12-19 18:22   ` Greg KH
2023-12-19 18:35     ` Tanzir Hasan
2023-12-19 19:10       ` Greg KH
2023-12-19 23:00         ` Nick Desaulniers
2023-12-20  6:03           ` Greg KH
2023-12-19 21:47   ` Andy Shevchenko
2023-12-19 18:09 ` [PATCH v4 2/2] lib/string: shrink lib/string.i via IWYU Tanzir Hasan
2023-12-19 18:24   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023121926-mummy-gondola-0a56@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=andy@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nnn@google.com \
    --cc=tanzirh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®