From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C4A3D0A2 for ; Tue, 19 Dec 2023 18:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fMcxRgA0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8319FC433C8; Tue, 19 Dec 2023 18:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1703009585; bh=LPaEVsI1WdhCKCTN3sP4iLdz4YB74R0k2T+UOI2ugCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fMcxRgA0wqBB/v32dxHnl8xDSGNkzjSK0llDH98uVSm7uXZHKuZv+fv99fRGEs3zs UvyToxzClXvMSx1ALgfrhKXI15to4JixvrGoZHqnx4HKnOOVj5vfw4mbB5EFPo1OgT Kf2N9hyuZkIRCgTWEZB2h+Zy089AF0Vfz+wihEEs= Date: Tue, 19 Dec 2023 19:13:03 +0100 From: Greg Kroah-Hartman To: "Ertman, David M" Cc: "rafael@kernel.org" , "linux-kernel@vger.kernel.org" , "Weiny, Ira" , William Breathitt Gray , David Hildenbrand , Oscar Salvador , Kevin Hilman , Ulf Hansson , "Brown, Len" Subject: Re: [PATCH] driver core: mark remaining local bus_type variables as const Message-ID: <2023121943-slather-collide-f61c@gregkh> References: <2023121908-paver-follow-cc21@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 19, 2023 at 06:02:33PM +0000, Ertman, David M wrote: > > -----Original Message----- > > From: Greg Kroah-Hartman > > Sent: Tuesday, December 19, 2023 7:35 AM > > To: rafael@kernel.org; linux-kernel@vger.kernel.org > > Cc: Greg Kroah-Hartman ; Ertman, David M > > ; Weiny, Ira ; William > > Breathitt Gray ; David Hildenbrand > > ; Oscar Salvador ; Kevin Hilman > > ; Ulf Hansson ; Brown, Len > > > > Subject: [PATCH] driver core: mark remaining local bus_type variables as > > const > > > > Now that the driver core can properly handle constant struct bus_type, > > change the local driver core bus_type variables to be a constant > > structure as well, placing them into read-only memory which can not be > > modified at runtime. > > > > Cc: Dave Ertman > > Cc: Ira Weiny > > Cc: "Rafael J. Wysocki" > > Cc: William Breathitt Gray > > Cc: David Hildenbrand > > Cc: Oscar Salvador > > Cc: Kevin Hilman > > Cc: Ulf Hansson > > Cc: Len Brown > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/base/auxiliary.c | 2 +- > > drivers/base/isa.c | 2 +- > > drivers/base/memory.c | 2 +- > > drivers/base/node.c | 2 +- > > drivers/base/power/domain.c | 2 +- > > drivers/base/soc.c | 2 +- > > 6 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > > index 4d4c2c8d26c4..d3a2c40c2f12 100644 > > --- a/drivers/base/auxiliary.c > > +++ b/drivers/base/auxiliary.c > > @@ -244,7 +244,7 @@ static void auxiliary_bus_shutdown(struct device > > *dev) > > auxdrv->shutdown(auxdev); > > } > > > > -static struct bus_type auxiliary_bus_type = { > > +static const struct bus_type auxiliary_bus_type = { > > .name = "auxiliary", > > .probe = auxiliary_bus_probe, > > .remove = auxiliary_bus_remove, > > diff --git a/drivers/base/isa.c b/drivers/base/isa.c > > index 675ad3139224..e23d0b49a793 100644 > > --- a/drivers/base/isa.c > > +++ b/drivers/base/isa.c > > LGTM - ACK So, is that an "Acked-by:" type response? We need something standard for our tools to pick up... thanks, greg k-h