From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Bjorn Andersson" <quic_bjorande@quicinc.com>
Subject: [PATCH 2/8] clk: qcom: gdsc: Enable supply reglator in GPU GX handler
Date: Wed, 20 Dec 2023 19:50:36 -0800 [thread overview]
Message-ID: <20231220-sa8295p-gpu-v1-2-d8cdf2257f97@quicinc.com> (raw)
In-Reply-To: <20231220-sa8295p-gpu-v1-0-d8cdf2257f97@quicinc.com>
The GX GDSC is modelled to aid the GMU in powering down the GPU in the
event that the GPU crashes, so that it can be restarted again. But in
the event that the power-domain is supplied through a dedicated
regulator (in contrast to being a subdomin of another power-domain),
something needs to turn that regulator on, both to make sure things are
powered and to match the operation in gdsc_disable().
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
drivers/clk/qcom/gdsc.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
index 5358e28122ab..d1139c895503 100644
--- a/drivers/clk/qcom/gdsc.c
+++ b/drivers/clk/qcom/gdsc.c
@@ -557,7 +557,13 @@ void gdsc_unregister(struct gdsc_desc *desc)
*/
int gdsc_gx_do_nothing_enable(struct generic_pm_domain *domain)
{
+ struct gdsc *sc = domain_to_gdsc(domain);
+ int ret = 0;
+
/* Do nothing but give genpd the impression that we were successful */
- return 0;
+ if (sc->rsupply)
+ ret = regulator_enable(sc->rsupply);
+
+ return ret;
}
EXPORT_SYMBOL_GPL(gdsc_gx_do_nothing_enable);
--
2.25.1
next prev parent reply other threads:[~2023-12-21 3:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 3:50 [PATCH 0/8] arm64: dts: qcom: sa8295p: Enable GPU Bjorn Andersson
2023-12-21 3:50 ` [PATCH 1/8] dt-bindings: clock: qcom: Allow VDD_GFX supply to GX Bjorn Andersson
2023-12-21 7:03 ` Dmitry Baryshkov
2023-12-21 7:10 ` Dmitry Baryshkov
2023-12-21 19:16 ` Bjorn Andersson
2023-12-21 3:50 ` Bjorn Andersson [this message]
2023-12-21 4:36 ` [PATCH 2/8] clk: qcom: gdsc: Enable supply reglator in GPU GX handler Stephen Boyd
2023-12-21 12:57 ` Konrad Dybcio
2023-12-21 13:04 ` Dmitry Baryshkov
2023-12-21 13:16 ` Konrad Dybcio
2023-12-21 13:17 ` Konrad Dybcio
2023-12-21 13:18 ` Dmitry Baryshkov
2023-12-21 3:50 ` [PATCH 3/8] clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc Bjorn Andersson
2023-12-21 7:04 ` Dmitry Baryshkov
2023-12-21 3:50 ` [PATCH 4/8] soc: qcom: rpmhpd: Drop SA8540P gfx.lvl Bjorn Andersson
2023-12-21 7:05 ` Dmitry Baryshkov
2023-12-21 3:50 ` [PATCH 5/8] arm64: dts: qcom: sa8540p: Drop gfx.lvl as power-domain for gpucc Bjorn Andersson
2023-12-21 7:06 ` Dmitry Baryshkov
2023-12-21 3:50 ` [PATCH 6/8] arm64: dts: qcom: sa8295p-adp: add max20411 Bjorn Andersson
2023-12-21 7:07 ` Dmitry Baryshkov
2023-12-21 12:51 ` Konrad Dybcio
2023-12-21 18:48 ` Bjorn Andersson
2023-12-21 3:50 ` [PATCH 7/8] arm64: dts: qcom: sa8295p-adp: Enable GPU Bjorn Andersson
2023-12-21 7:09 ` Dmitry Baryshkov
2023-12-21 3:50 ` [PATCH 8/8] arm64: defconfig: Enable MAX20411 regulator driver Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220-sa8295p-gpu-v1-2-d8cdf2257f97@quicinc.com \
--to=quic_bjorande@quicinc.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®