From: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
To: tiwai@suse.de
Cc: alex.vinarskis@gmail.com, alsa-devel@alsa-project.org,
david.rhodes@cirrus.com, james.schulman@cirrus.com,
josbeir@gmail.com, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, perex@perex.cz,
sbinding@opensource.cirrus.com, stuarth@opensource.cirrus.com,
tiwai@suse.com
Subject: [PATCH v2 1/2] ALSA: hda: cs35l41: Safety-guard against capped SPI speed
Date: Wed, 20 Dec 2023 08:38:08 +0100 [thread overview]
Message-ID: <20231220073809.22027-2-alex.vinarskis@gmail.com> (raw)
In-Reply-To: <20231220073809.22027-1-alex.vinarskis@gmail.com>
Some devices with intel-lpss based SPI controllers may have misconfigured
clock divider due to firmware bug. This would result in capped SPI speeds,
which leads to longer DSP firmware loading times.
This safety guards against possible hangs during wake-up by not
initializing the device if lpss was not patched/fixed UEFI was not
installed
Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
sound/pci/hda/cs35l41_hda_property.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index c9eb70290973..cb305b093311 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -210,6 +210,19 @@ static int generic_dsd_config(struct cs35l41_hda *cs35l41, struct device *physde
if (cfg->bus == SPI) {
cs35l41->index = id;
+ /*
+ * Some devices with intel-lpss based SPI controllers may have misconfigured
+ * clock divider due to firmware bug. This would result in capped SPI speeds,
+ * which leads to longer DSP firmware loading times.
+ * Avoid initializing device if lpss was not patched/fixed UEFI was not installed
+ */
+ spi = to_spi_device(cs35l41->dev);
+ if (spi->max_speed_hz < CS35L41_SPI_MAX_FREQ/2) {
+ dev_err(cs35l41->dev,
+ "SPI's max_speed_hz is capped at %u Hz, will not continue to avoid hanging\n",
+ spi->max_speed_hz);
+ return -EINVAL;
+ }
/*
* Manually set the Chip Select for the second amp <cs_gpio_index> in the node.
* This is only supported for systems with 2 amps, since we cannot expand the
@@ -219,8 +232,6 @@ static int generic_dsd_config(struct cs35l41_hda *cs35l41, struct device *physde
* first.
*/
if (cfg->cs_gpio_index >= 0) {
- spi = to_spi_device(cs35l41->dev);
-
if (cfg->num_amps != 2) {
dev_warn(cs35l41->dev,
"Cannot update SPI CS, Number of Amps (%d) != 2\n",
--
2.40.1
next prev parent reply other threads:[~2023-12-20 7:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 19:52 [PATCH 1/1] ALSA: hda: cs35l41: Dell Fiorano add missing _DSD properties Aleksandrs Vinarskis
2023-12-14 11:02 ` Takashi Iwai
2023-12-14 15:39 ` Stuart Henderson
2023-12-14 15:49 ` Takashi Iwai
2023-12-14 19:36 ` Aleksandrs Vinarskis
2023-12-18 11:51 ` Andy Shevchenko
2023-12-20 7:38 ` [PATCH v2 0/2] ALSA: hda: cs35l41: Support Dell XPS 9530 (2023) Aleksandrs Vinarskis
2023-12-20 7:38 ` Aleksandrs Vinarskis [this message]
2023-12-20 13:43 ` [PATCH v2 1/2] ALSA: hda: cs35l41: Safety-guard against capped SPI speed Stefan Binding
2023-12-21 11:24 ` Aleksandrs Vinarskis
2023-12-21 15:09 ` Stefan Binding
2023-12-20 7:38 ` [PATCH v2 2/2] ALSA: hda: cs35l41: Support Dell XPS 9530 (2023) Aleksandrs Vinarskis
2023-12-20 13:47 ` Stefan Binding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220073809.22027-2-alex.vinarskis@gmail.com \
--to=alex.vinarskis@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=josbeir@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=stuarth@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®