From: Junwen Wu <wudaemon@163.com>
To: laoar.shao@gmail.com
Cc: bristot@redhat.com, bsegall@google.com, dietmar.eggemann@arm.com,
juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
mgorman@suse.de, mingo@redhat.com, peterz@infradead.org,
rostedt@goodmis.org, vincent.guittot@linaro.org,
vschneid@redhat.com, wudaemon@163.com
Subject: Re: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error in sched_stat_wait trace_point
Date: Wed, 20 Dec 2023 14:32:49 +0000 [thread overview]
Message-ID: <20231220143249.833273-1-wudaemon@163.com> (raw)
In-Reply-To: <20231220140112.821992-1-wudaemon@163.com>
>>I think we'd better use if (!on_rt_rq(rt_se))
>>
>> + update_stats_wait_end_rt(rt_rq, rt_se);
>>
hi, Yafang.when execute update_stats_dequeue_rt, rt_se->on_rq is still 0, util dequeue_rt_stack,
the method is not effect.
I this we can use if (p && p != rq->curr) /*Mark the end of the wait period if dequeueing task*/
because schedstats is not supported for rt group,we only need to update rt_se that is realy task.
--
Best regards
next prev parent reply other threads:[~2023-12-20 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:03 [PATCH v1] sched/rt: Fix rt task's sched latency statistics " Junwen Wu
2023-12-19 12:35 ` Yafang Shao
2023-12-19 14:53 ` Junwen Wu
2023-12-20 14:01 ` Junwen Wu
2023-12-20 14:32 ` Junwen Wu [this message]
2023-12-20 14:40 ` [PATCH v1] sched/rt: Fix rt task's sched latency statistics error " Junwen Wu
2023-12-20 15:18 ` Yafang Shao
2023-12-21 14:50 ` Junwen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220143249.833273-1-wudaemon@163.com \
--to=wudaemon@163.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®