Re: [PATCH] tracing / synthetic: Disable events after testing in synth_event_gen_test_init()

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 21 Dec 2023 11:06:38 +0100
Alexander Graf <graf@amazon.com> wrote:

> Thanks a bunch for the super quick turnaround time for the fix! I can 
> confirm that I'm no longer seeing the warning :)
> 
> Tested-by: Alexander Graf <graf@amazon.com>

Thanks Alex,

> 
> 
> Do we need another similar patch for the kprobe self tests? The below is 
> with 55cb5f43689d7 plus an unrelated initrd patch plus this patch and 
> the following .config: http://csgraf.de/tmp2/config-ftrace.xz

Sure, now you tell me ;-)

I just finished all my tests and will be sending Linus a pull request soon.

I'll let Masami handle this one, as it's under his department.

-- Steve

> 
> [  919.717134] Testing all events: OK
> [  924.418194] Testing ftrace filter: OK
> [  924.418887] trace_kprobe: Testing kprobe tracing:
> [  924.424244] ------------[ cut here ]------------
> [  924.424952] WARNING: CPU: 2 PID: 1 at 
> kernel/trace/trace_kprobe.c:2073 kprobe_trace_self_tests_init+0x192/0x540
> [  924.425659] Modules linked in:
> [  924.425886] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 
> 6.7.0-rc6-00024-gc10698ad3c9a #298
> [  924.426448] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 
> rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014
> [  924.427230] RIP: 0010:kprobe_trace_self_tests_init+0x192/0x540
> [  924.427639] Code: 7e 10 74 3b 48 8b 36 48 39 d6 75 f2 0f 0b 48 c7 c7 
> 58 71 79 a5 e8 ee 3e 5a fe 48 c7 c7 20 38 b7 a5 e8 a2 51 68 fe 85 c0 74 
> 33 <0f> 0b 48 c7 c7 38 73 79 a5 e8 d0 3e 5a fe e8 4b 64 62 fe eb 23 48
> [  924.428922] RSP: 0000:ffffab508001be58 EFLAGS: 00010286
> [  924.429288] RAX: 00000000fffffff0 RBX: 000000000000005a RCX: 
> 0000000000000202
> [  924.429800] RDX: 0000000000000000 RSI: 000000000002e970 RDI: 
> ffffffffa5b708a0
> [  924.430295] RBP: 0000000000000000 R08: 0000000000000001 R09: 
> ffffffffa4855a90
> [  924.430794] R10: 0000000000000007 R11: 000000000000028a R12: 
> 0000000000000001
> [  924.431286] R13: ffffffffa5cc9a00 R14: ffff8cec81bebe00 R15: 
> ffffffffa619f0f0
> [  924.431785] FS:  0000000000000000(0000) GS:ffff8cecf9100000(0000) 
> knlGS:0000000000000000
> [  924.432346] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  924.432748] CR2: 0000000000000000 CR3: 000000004883e001 CR4: 
> 00000000003706f0
> [  924.433246] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 
> 0000000000000000
> [  924.433739] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 
> 0000000000000400
> [  924.434233] Call Trace:
> [  924.434418]  <TASK>
> [  924.434569]  ? __warn+0x7d/0x140
> [  924.434807]  ? kprobe_trace_self_tests_init+0x192/0x540
> [  924.435172]  ? report_bug+0xf8/0x1e0
> [  924.435430]  ? handle_bug+0x3f/0x70
> [  924.435677]  ? exc_invalid_op+0x13/0x60
> [  924.435954]  ? asm_exc_invalid_op+0x16/0x20
> [  924.436249]  ? rdinit_setup+0x40/0x40
> [  924.436509]  ? trace_kprobe_release+0x70/0xb0
> [  924.436822]  ? kprobe_trace_self_tests_init+0x192/0x540
> [  924.437189]  ? kprobe_trace_self_tests_init+0x421/0x540
> [  924.437551]  ? init_kprobe_trace+0x1b0/0x1b0
> [  924.437855]  do_one_initcall+0x44/0x200
> [  924.438131]  kernel_init_freeable+0x1e8/0x330
> [  924.438439]  ? rest_init+0xd0/0xd0
> [  924.438682]  kernel_init+0x16/0x130
> [  924.438943]  ret_from_fork+0x30/0x50
> [  924.439202]  ? rest_init+0xd0/0xd0
> [  924.439445]  ret_from_fork_asm+0x11/0x20
> [  924.439734]  </TASK>
> [  924.439893] ---[ end trace 0000000000000000 ]---
> [  924.440217] trace_kprobe: error on cleaning up probes.
> [  924.440575] NG: Some tests are failed. Please check them.