From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>,
Naohiro.Aota@wdc.com, Lai Jiangshan <jiangshan.ljs@antgroup.com>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: [PATCH 5/7] workqueue: Addjust pwq's max_active when CPU online/offine
Date: Wed, 27 Dec 2023 22:51:41 +0800 [thread overview]
Message-ID: <20231227145143.2399-6-jiangshanlai@gmail.com> (raw)
In-Reply-To: <20231227145143.2399-1-jiangshanlai@gmail.com>
From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
pwq->max_active is going to be set based on the CPU online distribution
which might be changed when CPU online/offine.
Call into wq_adjust_pwqs_max_active() to update them when needed.
Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
---
kernel/workqueue.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index e0101b2b5fa3..d1c671597289 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -5590,10 +5590,15 @@ int workqueue_online_cpu(unsigned int cpu)
mutex_unlock(&wq_pool_attach_mutex);
}
- /* update pod affinity of unbound workqueues */
+ /*
+ * Update pod affinity of unbound workqueues, and update max_active
+ * for PWQs of all pods due to CPU online distribution changed.
+ */
list_for_each_entry(wq, &workqueues, list) {
- if (wq->unbound_attrs)
+ if (wq->unbound_attrs) {
wq_update_pod(wq, cpu, true);
+ wq_adjust_pwqs_max_active(wq);
+ }
}
mutex_unlock(&wq_pool_mutex);
@@ -5610,11 +5615,16 @@ int workqueue_offline_cpu(unsigned int cpu)
unbind_workers(cpu);
- /* update pod affinity of unbound workqueues */
+ /*
+ * Update pod affinity of unbound workqueues, and update max_active
+ * for PWQs of all pods due to CPU online distribution changed.
+ */
mutex_lock(&wq_pool_mutex);
list_for_each_entry(wq, &workqueues, list) {
- if (wq->unbound_attrs)
+ if (wq->unbound_attrs) {
wq_update_pod(wq, cpu, false);
+ wq_adjust_pwqs_max_active(wq);
+ }
}
mutex_unlock(&wq_pool_mutex);
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2023-12-27 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 14:51 [PATCH 0/7] workqueue: Share the same PWQ for the CPUs of a pod and distribute max_active across pods Lai Jiangshan
2023-12-27 14:51 ` [PATCH 1/7] workqueue: Reuse the default PWQ as much as possible Lai Jiangshan
2023-12-27 14:51 ` [PATCH 2/7] workqueue: Share the same PWQ for the CPUs of a pod Lai Jiangshan
2024-01-03 2:55 ` kernel test robot
2024-01-03 9:01 ` Lai Jiangshan
2023-12-27 14:51 ` [PATCH 3/7] workqueue: Add pwq_calculate_max_active() Lai Jiangshan
2023-12-27 14:51 ` [PATCH 4/7] workqueue: Wrap common code into wq_adjust_pwqs_max_active() Lai Jiangshan
2023-12-27 14:51 ` Lai Jiangshan [this message]
2023-12-27 14:51 ` [PATCH 6/7] workqueue: Implement system-wide max_active enforcement for unbound workqueues Lai Jiangshan
2023-12-27 23:06 ` Tejun Heo
2023-12-27 14:51 ` [PATCH 7/7] workqueue: Rename wq->saved_max_active to wq->max_active Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227145143.2399-6-jiangshanlai@gmail.com \
--to=jiangshanlai@gmail.com \
--cc=Naohiro.Aota@wdc.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®