From: Borislav Petkov <bp@alien8.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH] EDAC: constantify the struct bus_type usage
Date: Thu, 28 Dec 2023 16:00:03 +0100 [thread overview]
Message-ID: <20231228150003.GAZY2Nc38sAIa0bat/@fat_crate.local> (raw)
In-Reply-To: <2023121909-tribute-punctuate-4b22@gregkh>
On Tue, Dec 19, 2023 at 02:13:10PM +0100, Greg Kroah-Hartman wrote:
> In many places in the edac code, struct bus_type pointers are passed
> around and then eventually sent to the driver core, which can handle a
> constant pointer. So constantify all of the edac usage of these as well
> because the data in them is never modified by the edac code either.
"constantify", huh? Not enough words in the English language so let's do
new ones?
:-)
So what's the plan with this "constantification"?
Because:
drivers/edac/edac_module.c: In function ‘edac_subsys_init’:
drivers/edac/edac_module.c:80:38: warning: passing argument 1 of ‘subsys_system_register’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
80 | err = subsys_system_register(&edac_subsys, NULL);
| ^~~~~~~~~~~~
In file included from ./include/linux/edac.h:16,
from drivers/edac/edac_module.c:13:
./include/linux/device.h:75:45: note: expected ‘struct bus_type *’ but argument is of type ‘const struct bus_type *’
75 | int subsys_system_register(struct bus_type *subsys,
|
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-12-28 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 13:13 Greg Kroah-Hartman
2023-12-28 15:00 ` Borislav Petkov [this message]
2023-12-29 9:10 ` Greg Kroah-Hartman
2023-12-29 9:29 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228150003.GAZY2Nc38sAIa0bat/@fat_crate.local \
--to=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®