From: Andrew Morton <akpm@linux-foundation.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ming Lei <ming.lei@redhat.com>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH 3/9] lib/group_cpus: relax atomicity requirement in grp_spread_init_one()
Date: Fri, 29 Dec 2023 10:39:48 -0800 [thread overview]
Message-ID: <20231229103948.4a78a75a83962df0874d04f1@linux-foundation.org> (raw)
In-Reply-To: <20231228200936.2475595-4-yury.norov@gmail.com>
On Thu, 28 Dec 2023 12:09:30 -0800 Yury Norov <yury.norov@gmail.com> wrote:
> Because nmsk and irqmsk are stable, extra atomicity is not required.
>
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> NAKed-by: Ming Lei <ming.lei@redhat.com>
Well that's unusual. I suggest that the changelog at least describe the
objection, and its counterargument?
next prev parent reply other threads:[~2023-12-29 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 20:09 [PATCH v4 0/9] lib/group_cpus: rework grp_spread_init_one() and make it O(1) Yury Norov
2023-12-28 20:09 ` [PATCH 1/9] cpumask: introduce for_each_cpu_and_from() Yury Norov
2023-12-28 20:09 ` [PATCH 2/9] lib/group_cpus: optimize inner loop in grp_spread_init_one() Yury Norov
2024-01-02 0:59 ` Ming Lei
2023-12-28 20:09 ` [PATCH 3/9] lib/group_cpus: relax atomicity requirement " Yury Norov
2023-12-29 18:39 ` Andrew Morton [this message]
2023-12-29 18:45 ` Yury Norov
2023-12-28 20:09 ` [PATCH 4/9] lib/group_cpus: optimize outer loop " Yury Norov
2023-12-28 20:09 ` [PATCH 5/9] lib/group_cpus: don't zero cpumasks in group_cpus_evenly() on allocation Yury Norov
2023-12-28 20:09 ` [PATCH 6/9] lib/group_cpus: drop unneeded cpumask_empty() call in __group_cpus_evenly() Yury Norov
2023-12-28 20:09 ` [PATCH 7/9] cpumask: define cleanup function for cpumasks Yury Norov
2023-12-28 20:09 ` [PATCH 8/9] lib/group_cpus: rework group_cpus_evenly() Yury Norov
2023-12-28 20:09 ` [PATCH 9/9] lib/group_cpus: simplify group_cpus_evenly() for more Yury Norov
2024-01-20 2:50 [PATCH v5 0/9] lib/group_cpus: rework grp_spread_init_one() and make it O(1) Yury Norov
2024-01-20 2:50 ` [PATCH 3/9] lib/group_cpus: relax atomicity requirement in grp_spread_init_one() Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231229103948.4a78a75a83962df0874d04f1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®