From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbdCNA6M (ORCPT ); Mon, 13 Mar 2017 20:58:12 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36068 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752840AbdCNA6K (ORCPT ); Mon, 13 Mar 2017 20:58:10 -0400 Subject: Re: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands To: Doug Berger References: <20170314004142.4746-1-opendmb@gmail.com> <20170314004142.4746-10-opendmb@gmail.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, davem@davemloft.net, rafal@milecki.pl, xow@google.com, joel@jms.id.au, jon.mason@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pgynther@google.com, jaedon.shin@gmail.com From: Florian Fainelli Message-ID: <2023a5c6-bf5d-aacd-366b-950f01efbe8c@gmail.com> Date: Mon, 13 Mar 2017 17:57:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170314004142.4746-10-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2017 05:41 PM, Doug Berger wrote: > This commit changes the ioctl handling behavior to return the > EOPNOTSUPP error code instead of the EINVAL error code when an > unknown ioctl command value is detected. > > It also removes some redundant parsing of the ioctl command value > and allows the SIOCSHWTSTAMP value to be handled. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian