From: Shrikanth Hegde <sshegde@linux.vnet.ibm.com>
To: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org
Cc: sshegde@linux.vnet.ibm.com, dietmar.eggemann@arm.com,
linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com,
yu.c.chen@intel.com, tim.c.chen@linux.intel.com
Subject: [PATCH v2 1/2] sched: use existing helper functions to access ->avg_rt and ->avg_dl
Date: Mon, 1 Jan 2024 21:16:23 +0530 [thread overview]
Message-ID: <20240101154624.100981-2-sshegde@linux.vnet.ibm.com> (raw)
In-Reply-To: <20240101154624.100981-1-sshegde@linux.vnet.ibm.com>
There are helper functions called cpu_util_dl and cpu_util_rt which gives
the average utilization of DL and RT respectively. But there are few
places in code where these variables are used directly.
Instead use the helper function so that code becomes simpler and easy to
maintain later on. This patch doesn't intend any functional changes.
Signed-off-by: Shrikanth Hegde <sshegde@linux.vnet.ibm.com>
---
kernel/sched/fair.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index bcea3d55d95d..1aeca3f943a8 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9212,10 +9212,10 @@ static inline bool cfs_rq_has_blocked(struct cfs_rq *cfs_rq)
static inline bool others_have_blocked(struct rq *rq)
{
- if (READ_ONCE(rq->avg_rt.util_avg))
+ if (cpu_util_rt(rq))
return true;
- if (READ_ONCE(rq->avg_dl.util_avg))
+ if (cpu_util_dl(rq))
return true;
if (thermal_load_avg(rq))
@@ -9481,8 +9481,8 @@ static unsigned long scale_rt_capacity(int cpu)
* avg_thermal.load_avg tracks thermal pressure and the weighted
* average uses the actual delta max capacity(load).
*/
- used = READ_ONCE(rq->avg_rt.util_avg);
- used += READ_ONCE(rq->avg_dl.util_avg);
+ used = cpu_util_rt(rq);
+ used += cpu_util_dl(rq);
used += thermal_load_avg(rq);
if (unlikely(used >= max))
--
2.39.3
next prev parent reply other threads:[~2024-01-01 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 15:46 [PATCH v2 0/2] sched: use existing helper function for accessing avg_rt, avg_dl and avg_irq Shrikanth Hegde
2024-01-01 15:46 ` Shrikanth Hegde [this message]
2024-01-04 14:27 ` [PATCH v2 1/2] sched: use existing helper functions to access ->avg_rt and ->avg_dl Vincent Guittot
2024-02-28 22:00 ` [tip: sched/core] sched/fair: Use " tip-bot2 for Shrikanth Hegde
2024-01-01 15:46 ` [PATCH v2 2/2] sched: add READ_ONCE and use existing helper function to access ->avg_irq Shrikanth Hegde
2024-01-04 14:28 ` Vincent Guittot
2024-02-28 22:00 ` [tip: sched/core] sched/fair: Add READ_ONCE() " tip-bot2 for Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240101154624.100981-2-sshegde@linux.vnet.ibm.com \
--to=sshegde@linux.vnet.ibm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®