From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Nick Terrell <terrelln@fb.com>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kajol Jain <kjain@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Huacai Chen <chenhuacai@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
"Steinar H. Gunderson" <sesse@google.com>,
Liam Howlett <liam.howlett@oracle.com>,
Miguel Ojeda <ojeda@kernel.org>,
Colin Ian King <colin.i.king@gmail.com>,
Dmitrii Dolgov <9erthalion6@gmail.com>,
Yang Jihong <yangjihong1@huawei.com>,
Ming Wang <wangming01@loongson.cn>,
James Clark <james.clark@arm.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Sean Christopherson <seanjc@google.com>,
Leo Yan <leo.yan@linaro.org>,
Ravi Bangoria <ravi.bangoria@amd.com>,
German Gomez <german.gomez@arm.com>,
Changbin Du <changbin.du@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>, Li Dong <lidong@vivo.com>,
Sandipan Das <sandipan.das@amd.com>,
liuwenyu <liuwenyu7@huawei.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Guilherme Amadio <amadio@gentoo.org>
Subject: [PATCH v7 13/25] perf threads: Reduce table size from 256 to 8
Date: Tue, 2 Jan 2024 21:06:23 -0800 [thread overview]
Message-ID: <20240103050635.391888-14-irogers@google.com> (raw)
In-Reply-To: <20240103050635.391888-1-irogers@google.com>
The threads data structure is an array of hashmaps, previously
rbtrees. The two levels allows for a fixed outer array where access is
guarded by rw_semaphores. Commit 91e467bc568f ("perf machine: Use
hashtable for machine threads") sized the outer table at 256 entries
to avoid future scalability problems, however, this means the threads
struct is sized at 30,720 bytes. As the hashmaps allow O(1) access for
the common find/insert/remove operations, lower the number of entries
to 8. This reduces the size overhead to 960 bytes.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/threads.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/threads.h b/tools/perf/util/threads.h
index d03bd91a7769..da68d2223f18 100644
--- a/tools/perf/util/threads.h
+++ b/tools/perf/util/threads.h
@@ -7,7 +7,7 @@
struct thread;
-#define THREADS__TABLE_BITS 8
+#define THREADS__TABLE_BITS 3
#define THREADS__TABLE_SIZE (1 << THREADS__TABLE_BITS)
struct threads_table_entry {
--
2.43.0.472.g3155946c3a-goog
next prev parent reply other threads:[~2024-01-03 5:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 5:06 [PATCH v7 00/25] maps/threads/dsos memory improvements and fixes Ian Rogers
2024-01-03 5:06 ` [PATCH v7 01/25] perf maps: Switch from rbtree to lazily sorted array for addresses Ian Rogers
2024-02-02 2:48 ` Namhyung Kim
2024-02-02 4:20 ` Ian Rogers
2024-02-02 4:21 ` Ian Rogers
2024-02-06 0:37 ` Namhyung Kim
2024-01-03 5:06 ` [PATCH v7 02/25] perf maps: Get map before returning in maps__find Ian Rogers
2024-01-03 5:06 ` [PATCH v7 03/25] perf maps: Get map before returning in maps__find_by_name Ian Rogers
2024-01-03 5:06 ` [PATCH v7 04/25] perf maps: Get map before returning in maps__find_next_entry Ian Rogers
2024-01-03 5:06 ` [PATCH v7 05/25] perf maps: Hide maps internals Ian Rogers
2024-01-03 5:06 ` [PATCH v7 06/25] perf maps: Locking tidy up of nr_maps Ian Rogers
2024-01-03 5:06 ` [PATCH v7 07/25] perf dso: Reorder variables to save space in struct dso Ian Rogers
2024-01-03 5:06 ` [PATCH v7 08/25] perf report: Sort child tasks by tid Ian Rogers
2024-01-03 5:06 ` [PATCH v7 09/25] perf trace: Ignore thread hashing in summary Ian Rogers
2024-01-03 5:06 ` [PATCH v7 10/25] perf machine: Move fprintf to for_each loop and a callback Ian Rogers
2024-01-03 5:06 ` [PATCH v7 11/25] perf threads: Move threads to its own files Ian Rogers
2024-01-03 5:06 ` [PATCH v7 12/25] perf threads: Switch from rbtree to hashmap Ian Rogers
2024-01-03 5:06 ` Ian Rogers [this message]
2024-01-03 5:06 ` [PATCH v7 14/25] perf dsos: Attempt to better abstract dsos internals Ian Rogers
2024-01-03 5:06 ` [PATCH v7 15/25] perf dsos: Tidy reference counting and locking Ian Rogers
2024-01-03 5:06 ` [PATCH v7 16/25] perf dsos: Add dsos__for_each_dso Ian Rogers
2024-01-03 5:06 ` [PATCH v7 17/25] perf dso: Move dso functions out of dsos Ian Rogers
2024-01-03 5:06 ` [PATCH v7 18/25] perf dsos: Switch more loops to dsos__for_each_dso Ian Rogers
2024-01-03 5:06 ` [PATCH v7 19/25] perf dsos: Switch backing storage to array from rbtree/list Ian Rogers
2024-01-03 5:06 ` [PATCH v7 20/25] perf dsos: Remove __dsos__addnew Ian Rogers
2024-01-03 5:06 ` [PATCH v7 21/25] perf dsos: Remove __dsos__findnew_link_by_longname_id Ian Rogers
2024-01-03 5:06 ` [PATCH v7 22/25] perf dsos: Switch hand code to bsearch Ian Rogers
2024-01-03 5:06 ` [PATCH v7 23/25] perf dso: Add reference count checking and accessor functions Ian Rogers
2024-01-03 5:06 ` [PATCH v7 24/25] perf dso: Reference counting related fixes Ian Rogers
2024-01-03 5:06 ` [PATCH v7 25/25] perf dso: Use container_of to avoid a pointer in dso_data Ian Rogers
2024-01-31 22:22 ` [PATCH v7 00/25] maps/threads/dsos memory improvements and fixes Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103050635.391888-14-irogers@google.com \
--to=irogers@google.com \
--cc=9erthalion6@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=amadio@gentoo.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=changbin.du@huawei.com \
--cc=chenhuacai@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kprateek.nayak@amd.com \
--cc=leo.yan@linaro.org \
--cc=liam.howlett@oracle.com \
--cc=lidong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuwenyu7@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ojeda@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=sesse@google.com \
--cc=terrelln@fb.com \
--cc=vincent.whitchurch@axis.com \
--cc=wangming01@loongson.cn \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®