From: Brad Cowie <brad@faucet.nz>
To: aconole@redhat.com
Cc: brad@faucet.nz, coreteam@netfilter.org, davem@davemloft.net,
dev@openvswitch.org, edumazet@google.com, fw@strlen.de,
horms@kernel.org, kadlec@netfilter.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, lucien.xin@gmail.com,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pabeni@redhat.com, pablo@netfilter.org
Subject: Re: [PATCH net] netfilter: nf_nat: fix action not being set for all ct states
Date: Thu, 4 Jan 2024 18:04:52 +1300 [thread overview]
Message-ID: <20240104050452.808076-1-brad@faucet.nz> (raw)
In-Reply-To: <f7tle97eppk.fsf@redhat.com>
On Wed, 3 Jan 2024 at 04:10, Aaron Conole <aconole@redhat.com> wrote:
> LGTM. I guess we should try to codify the specific flows that were used
> to flag this into the ovs selftest - we clearly have a missing case
> after NAT lookup.
Thanks for the review Aaron, and the sensible suggestion to add a
test to ovs to avoid this problem occuring again in future.
I've simplified our NAT ruleset and turned it into an ovs system test,
which I've submitted as a patch [1] to ovs-dev. The test reproduces
the issue introduced by ebddb1404900 and passes when e6345d2824a3
is applied.
[1]: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410476.html
prev parent reply other threads:[~2024-01-04 5:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 22:43 Brad Cowie
2023-12-23 21:13 ` Simon Horman
2023-12-24 2:47 ` Brad Cowie
2023-12-28 15:59 ` Xin Long
2024-01-02 15:10 ` Aaron Conole
2024-01-03 10:26 ` Pablo Neira Ayuso
2024-01-04 5:04 ` Brad Cowie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104050452.808076-1-brad@faucet.nz \
--to=brad@faucet.nz \
--cc=aconole@redhat.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®