From: David Sterba <dsterba@suse.cz>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org,
syzbot+be14ed7728594dc8bd42@syzkaller.appspotmail.com,
syzbot+c563a3c79927971f950f@syzkaller.appspotmail.com
Subject: Re: [PATCH] btrfs: ref-verify: free ref cache before clearing mount opt
Date: Thu, 4 Jan 2024 17:00:09 +0100 [thread overview]
Message-ID: <20240104160009.GF15380@twin.jikos.cz> (raw)
In-Reply-To: <20240103103128.30095-1-pchelkin@ispras.ru>
On Wed, Jan 03, 2024 at 01:31:27PM +0300, Fedor Pchelkin wrote:
> As clearing REF_VERIFY mount option indicates there were some errors in a
> ref-verify process, a ref cache is not relevant anymore and should be
> freed.
>
> btrfs_free_ref_cache() requires REF_VERIFY option being set so call
> it just before clearing the mount option.
>
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>
> Fixes: fd708b81d972 ("Btrfs: add a extent ref verify tool")
> Reported-by: syzbot+be14ed7728594dc8bd42@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/lkml/000000000000e5a65c05ee832054@google.com/
> Reported-by: syzbot+c563a3c79927971f950f@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/lkml/0000000000007fe09705fdc6086c@google.com/
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Added to misc-next, thanks.
prev parent reply other threads:[~2024-01-04 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 10:31 Fedor Pchelkin
2024-01-04 3:41 ` Anand Jain
2024-01-04 16:00 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104160009.GF15380@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=pchelkin@ispras.ru \
--cc=syzbot+be14ed7728594dc8bd42@syzkaller.appspotmail.com \
--cc=syzbot+c563a3c79927971f950f@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®