From: Xuewen Yan <xuewen.yan@unisoc.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <will@kernel.org>,
<boqun.feng@gmail.com>
Cc: <longman@redhat.com>, <zhiguo.niu@unisoc.com>,
<ke.wang@unisoc.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] lockdep: Add missing graph_unlock in check_prev_add
Date: Fri, 5 Jan 2024 14:04:56 +0800 [thread overview]
Message-ID: <20240105060456.15331-1-xuewen.yan@unisoc.com> (raw)
The check_prev_add() is held graph_lock, and it should unlock
the graph_lock before return 0.
But there is one condition where it will return 0 without unlock,
that is:
/* <prev> is not found in <next>::locks_before */
return 0;
So add graph_unlock before return 0.
Fixes: 3454a36d6a39 ("lockdep: Introduce lock_list::dep")
Signed-off-by: Xuewen Yan <xuewen.yan@unisoc.com>
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
---
Change in V2:
-move the graph_unlock to check_prev_add from validate_chain(Boqun)
-Add fix tag
---
---
kernel/locking/lockdep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 151bd3de5936..c8602a251bec 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -3178,6 +3178,7 @@ check_prev_add(struct task_struct *curr, struct held_lock *prev,
}
/* <prev> is not found in <next>::locks_before */
+ graph_unlock();
return 0;
}
}
--
2.25.1
next reply other threads:[~2024-01-05 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 6:04 Xuewen Yan [this message]
2024-01-09 3:49 ` Waiman Long
2024-01-09 5:11 ` Xuewen Yan
2024-01-09 15:40 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105060456.15331-1-xuewen.yan@unisoc.com \
--to=xuewen.yan@unisoc.com \
--cc=boqun.feng@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®