mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 02/21] Staging: rtl8192e: Rename variable SlotIndex
Date: Fri,  5 Jan 2024 21:55:37 -0800	[thread overview]
Message-ID: <20240106055556.430948-3-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240106055556.430948-1-tdavies@darkphysics.net>

Rename variable SlotIndex to slot_index to fix checkpatch
warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++----
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c   | 8 ++++----
 drivers/staging/rtl8192e/rtllib.h              | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c      | 2 +-
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index c7a2eae2fdb9..9b9d95ba06df 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1852,7 +1852,7 @@ bool rtl92e_is_rx_stuck(struct net_device *dev)
 	u16		  RegRxCounter = rtl92e_readw(dev, 0x130);
 	bool		  bStuck = false;
 	static u8	  rx_chk_cnt;
-	u32		SlotIndex = 0, TotalRxStuckCount = 0;
+	u32		slot_index = 0, TotalRxStuckCount = 0;
 	u8		i;
 	u8		SilentResetRxSoltNum = 4;
 
@@ -1882,10 +1882,10 @@ bool rtl92e_is_rx_stuck(struct net_device *dev)
 	}
 
 
-	SlotIndex = (priv->silent_reset_rx_slot_index++) % SilentResetRxSoltNum;
+	slot_index = (priv->silent_reset_rx_slot_index++) % SilentResetRxSoltNum;
 
 	if (priv->rx_ctr == RegRxCounter) {
-		priv->silent_reset_rx_stuck_event[SlotIndex] = 1;
+		priv->silent_reset_rx_stuck_event[slot_index] = 1;
 
 		for (i = 0; i < SilentResetRxSoltNum; i++)
 			TotalRxStuckCount += priv->silent_reset_rx_stuck_event[i];
@@ -1897,7 +1897,7 @@ bool rtl92e_is_rx_stuck(struct net_device *dev)
 					 priv->silent_reset_rx_stuck_event[i];
 		}
 	} else {
-		priv->silent_reset_rx_stuck_event[SlotIndex] = 0;
+		priv->silent_reset_rx_stuck_event[slot_index] = 0;
 	}
 
 	priv->rx_ctr = RegRxCounter;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 6815d18a7919..67938e212db1 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -915,17 +915,17 @@ static void _rtl92e_if_check_reset(struct net_device *dev)
 static void _rtl92e_update_rxcounts(struct r8192_priv *priv, u32 *TotalRxBcnNum,
 				    u32 *TotalRxDataNum)
 {
-	u16	SlotIndex;
+	u16	slot_index;
 	u8	i;
 
 	*TotalRxBcnNum = 0;
 	*TotalRxDataNum = 0;
 
-	SlotIndex = (priv->rtllib->link_detect_info.SlotIndex++) %
+	slot_index = (priv->rtllib->link_detect_info.slot_index++) %
 			(priv->rtllib->link_detect_info.SlotNum);
-	priv->rtllib->link_detect_info.RxBcnNum[SlotIndex] =
+	priv->rtllib->link_detect_info.RxBcnNum[slot_index] =
 			priv->rtllib->link_detect_info.NumRecvBcnInPeriod;
-	priv->rtllib->link_detect_info.RxDataNum[SlotIndex] =
+	priv->rtllib->link_detect_info.RxDataNum[slot_index] =
 			priv->rtllib->link_detect_info.NumRecvDataInPeriod;
 	for (i = 0; i < priv->rtllib->link_detect_info.SlotNum; i++) {
 		*TotalRxBcnNum += priv->rtllib->link_detect_info.RxBcnNum[i];
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 7b39a1987fdd..37bcd968a542 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1116,7 +1116,7 @@ struct rt_link_detect {
 	u32				RxBcnNum[RT_MAX_LD_SLOT_NUM];
 	u32				RxDataNum[RT_MAX_LD_SLOT_NUM];
 	u16				SlotNum;
-	u16				SlotIndex;
+	u16				slot_index;
 
 	u32				num_tx_ok_in_period;
 	u32				num_rx_ok_in_period;
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 520b90abcde7..1d490704389e 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -2072,7 +2072,7 @@ int rtllib_softmac_init(struct rtllib_device *ieee)
 	for (i = 0; i < 5; i++)
 		ieee->seq_ctrl[i] = 0;
 
-	ieee->link_detect_info.SlotIndex = 0;
+	ieee->link_detect_info.slot_index = 0;
 	ieee->link_detect_info.SlotNum = 2;
 	ieee->link_detect_info.NumRecvBcnInPeriod = 0;
 	ieee->link_detect_info.NumRecvDataInPeriod = 0;
-- 
2.39.2


  parent reply	other threads:[~2024-01-06  5:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06  5:55 [PATCH 00/21] Staging: rtl8192e: checkpatch fixes for rtllib_softmac.c Tree Davies
2024-01-06  5:55 ` [PATCH 01/21] Staging: rtl8192e: Remove unnecessary parenthesis in rtllib_softmac_new_net() Tree Davies
2024-01-06  5:55 ` Tree Davies [this message]
2024-01-06  5:55 ` [PATCH 03/21] Staging: rtl8192e: Rename function rtllib_MgntDisconnectAP() Tree Davies
2024-01-06  5:55 ` [PATCH 04/21] Staging: rtl8192e: Rename variable bMulticast Tree Davies
2024-01-06  5:55 ` [PATCH 05/21] Staging: rtl8192e: Rename variable MaxPeriod Tree Davies
2024-01-06  5:55 ` [PATCH 06/21] Staging: rtl8192e: Rename variable bAwakePktSent Tree Davies
2024-01-06  5:55 ` [PATCH 07/21] Staging: rtl8192e: Rename variable bSupportNmode Tree Davies
2024-01-06  5:55 ` [PATCH 08/21] Staging: rtl8192e: Rename variable bBusyTraffic Tree Davies
2024-01-06  5:55 ` [PATCH 09/21] Staging: rtl8192e: Rename function rtllib_MgntDisconnect() Tree Davies
2024-01-06  5:55 ` [PATCH 10/21] Staging: rtl8192e: Rename variable bFilterOutNonAssociatedBSSID Tree Davies
2024-01-06  5:55 ` [PATCH 11/21] Staging: rtl8192e: Rename variable array Bssid Tree Davies
2024-01-06  5:55 ` [PATCH 12/21] Staging: rtl8192e: Rename variable NumRxUnicastOkInPeriod Tree Davies
2024-01-06  5:55 ` [PATCH 13/21] Staging: rtl8192e: Rename variable SlotNum Tree Davies
2024-01-06  5:55 ` [PATCH 14/21] Staging: rtl8192e: Rename variable RemoveAllTS Tree Davies
2024-01-06  5:55 ` [PATCH 15/21] Staging: rtl8192e: Rename function RemovePeerTS() Tree Davies
2024-01-06  5:55 ` [PATCH 16/21] Staging: rtl8192e: Rename function rtllib_MlmeDisassociateRequest() Tree Davies
2024-01-06  5:55 ` [PATCH 17/21] Staging: rtl8192e: Rename function SendDisassociation() Tree Davies
2024-01-06  5:55 ` [PATCH 18/21] Staging: rtl8192e: Rename variable bHalfSupportNmode Tree Davies
2024-01-06  5:55 ` [PATCH 19/21] Staging: rtl8192e: Rename variable PMKCacheIdx Tree Davies
2024-01-06  5:55 ` [PATCH 20/21] Staging: rtl8192e: Rename function GetNmodeSupportBySecCfg() Tree Davies
2024-01-06  5:55 ` [PATCH 21/21] Staging: rtl8192e: Rename variable AsocRetryCount Tree Davies
2024-01-06 12:47 ` [PATCH 00/21] Staging: rtl8192e: checkpatch fixes for rtllib_softmac.c Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240106055556.430948-3-tdavies@darkphysics.net \
    --to=tdavies@darkphysics.net \
    --cc=anjan@momi.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®